Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-21 Thread Simon Glass
Hi, On Thu, Sep 15, 2011 at 10:41 AM, Mike Frysinger wrote: > On Thursday, September 15, 2011 13:30:09 Albert ARIBAUD wrote: >> I agree on the need and interest to support cache. I disagree on the way >> to get there. Turning cache off indiscriminately and hoping that board >> developers/maintain

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-15 Thread Mike Frysinger
On Thursday, September 15, 2011 13:30:09 Albert ARIBAUD wrote: > I agree on the need and interest to support cache. I disagree on the way > to get there. Turning cache off indiscriminately and hoping that board > developers/maintainer turn their caches off will only lead to U-Boot > failing in inte

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-15 Thread Albert ARIBAUD
Le 15/09/2011 18:31, Mike Frysinger a écrit : > On Thursday, September 15, 2011 12:21:28 Albert ARIBAUD wrote: >> Le 15/09/2011 05:03, Mike Frysinger a écrit : >>> On Wednesday, September 14, 2011 11:13:40 Simon Glass wrote: On Wed, Sep 14, 2011 at 6:10 AM, Aneesh V wrote: >> not specific

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-15 Thread Mike Frysinger
On Thursday, September 15, 2011 12:21:28 Albert ARIBAUD wrote: > Le 15/09/2011 05:03, Mike Frysinger a écrit : > > On Wednesday, September 14, 2011 11:13:40 Simon Glass wrote: > >> On Wed, Sep 14, 2011 at 6:10 AM, Aneesh V wrote: > not specific to your patch, but this seems kind of dumb to cop

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-15 Thread Albert ARIBAUD
Le 15/09/2011 05:03, Mike Frysinger a écrit : > On Wednesday, September 14, 2011 11:13:40 Simon Glass wrote: >> On Wed, Sep 14, 2011 at 6:10 AM, Aneesh V wrote: not specific to your patch, but this seems kind of dumb to copy& paste the same thing between all the arm sub arches/boards. w

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-14 Thread Mike Frysinger
On Wednesday, September 14, 2011 11:13:40 Simon Glass wrote: > On Wed, Sep 14, 2011 at 6:10 AM, Aneesh V wrote: > >> not specific to your patch, but this seems kind of dumb to copy & paste > >> the same thing between all the arm sub arches/boards. why cant the > >> default enable_caches() look lik

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-14 Thread Simon Glass
Hi Aneesh, On Wed, Sep 14, 2011 at 6:10 AM, Aneesh V wrote: [snip] >> not specific to your patch, but this seems kind of dumb to copy & paste the >> same thing between all the arm sub arches/boards.  why cant the default >> enable_caches() look like this for arm: >> void enable_caches(void) >> {

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-14 Thread Aneesh V
Hi Mike, On Friday 09 September 2011 05:55 AM, Mike Frysinger wrote: > On Thursday, September 08, 2011 18:20:16 Simon Glass wrote: >> --- a/board/nvidia/common/board.c >> +++ b/board/nvidia/common/board.c >> @@ -307,3 +307,11 @@ int board_mmc_getcd(u8 *cd, struct mmc *mmc) >> return 0; >> }

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-08 Thread Simon Glass
Hi, On Thu, Sep 8, 2011 at 5:30 PM, Marek Vasut wrote: > On Friday, September 09, 2011 02:25:46 AM Mike Frysinger wrote: >> On Thursday, September 08, 2011 18:20:16 Simon Glass wrote: >> > --- a/board/nvidia/common/board.c >> > +++ b/board/nvidia/common/board.c >> > @@ -307,3 +307,11 @@ int board

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-08 Thread Marek Vasut
On Friday, September 09, 2011 02:25:46 AM Mike Frysinger wrote: > On Thursday, September 08, 2011 18:20:16 Simon Glass wrote: > > --- a/board/nvidia/common/board.c > > +++ b/board/nvidia/common/board.c > > @@ -307,3 +307,11 @@ int board_mmc_getcd(u8 *cd, struct mmc *mmc) > > > > return 0; > >

Re: [U-Boot] [PATCH] tegra2: Enable data cache

2011-09-08 Thread Mike Frysinger
On Thursday, September 08, 2011 18:20:16 Simon Glass wrote: > --- a/board/nvidia/common/board.c > +++ b/board/nvidia/common/board.c > @@ -307,3 +307,11 @@ int board_mmc_getcd(u8 *cd, struct mmc *mmc) > return 0; > } > #endif > + > +#ifndef CONFIG_SYS_DCACHE_OFF > +void enable_caches(void) >

[U-Boot] [PATCH] tegra2: Enable data cache

2011-09-08 Thread Simon Glass
This enables the data cache on Tegra2 boards. Signed-off-by: Simon Glass --- board/nvidia/common/board.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c index 160dac8..031cc68 100644 --- a/board/nvidia/comm