Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Simon Glass
Hi Marcel, On 10 October 2014 16:44, Marcel Ziswiler wrote: > Hi Simon > > On Fri, 2014-10-10 at 16:22 -0600, Simon Glass wrote: >> Well you fixed that bug. Are there any others? > > Well, not in any of our boards but a short grep through the sources > reveals dozens of places where GPIOs are sti

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Marcel Ziswiler
Hi Simon On Fri, 2014-10-10 at 16:22 -0600, Simon Glass wrote: > Well you fixed that bug. Are there any others? Well, not in any of our boards but a short grep through the sources reveals dozens of places where GPIOs are still reserved with NULL labels. Happy crashing and subsequent bisecting for

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Simon Glass
Hi Marcel, On 10 October 2014 09:53, Marcel Ziswiler wrote: > Hi Simon > > On Fri, 2014-10-10 at 09:42 -0600, Simon Glass wrote: >> OK, is it possible to stop calling the function with NULL instead? > > Yes, sure. Remember > > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/198189 > >> Th

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Marcel Ziswiler
Hi Simon On Fri, 2014-10-10 at 09:42 -0600, Simon Glass wrote: > OK, is it possible to stop calling the function with NULL instead? Yes, sure. Remember http://article.gmane.org/gmane.comp.boot-loaders.u-boot/198189 > That is a bug IMO. Well, that's what I tried to find out digging through the

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Simon Glass
Hi Marcel, On 10 October 2014 09:37, Marcel Ziswiler wrote: > Hi Simon > > On Fri, 2014-10-10 at 09:26 -0600, Simon Glass wrote: >> Does this patch fix anything? What exactly does it change with your board? > > Well, yes. It does stop Colibri T30 from crashing with rc3 right after > printing DRAM

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Marcel Ziswiler
Hi Simon On Fri, 2014-10-10 at 09:26 -0600, Simon Glass wrote: > Does this patch fix anything? What exactly does it change with your board? Well, yes. It does stop Colibri T30 from crashing with rc3 right after printing DRAM: 1 GiB. Looking at the former code the string copy stuff was actually

Re: [U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Simon Glass
Hi Marcel, On 10 October 2014 08:56, Marcel Ziswiler wrote: > Fix Tegra GPIO driver to not crash resp. misbehave upon requesting > GPIOs with an empty aka NULL label. As the driver uses exclusively the > label to check for reservation status actually supplying one is > mandatory! > > This fixes a

[U-Boot] [PATCH] tegra: gpio: fix null label regression

2014-10-10 Thread Marcel Ziswiler
Fix Tegra GPIO driver to not crash resp. misbehave upon requesting GPIOs with an empty aka NULL label. As the driver uses exclusively the label to check for reservation status actually supplying one is mandatory! This fixes a regression introduced by commit: 2fccd2d96badcdf6165658a99771a4c4755862