Re: [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD

2015-01-21 Thread Simon Glass
HI Hans, On 21 January 2015 at 06:18, Hans de Goede wrote: > Hi, > > On 20-01-15 22:40, Tom Rini wrote: >> >> All of the code in arch/arm/cpu/armv7/sunxi/board.c was under a check >> for CONFIG_SPL_BUILD so instead only build for SPL. > > > That is not true, the #ifdef SPL block ends at the end o

Re: [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD

2015-01-21 Thread Tom Rini
On Wed, Jan 21, 2015 at 02:18:12PM +0100, Hans de Goede wrote: > Hi, > > On 20-01-15 22:40, Tom Rini wrote: > >All of the code in arch/arm/cpu/armv7/sunxi/board.c was under a check > >for CONFIG_SPL_BUILD so instead only build for SPL. > > That is not true, the #ifdef SPL block ends at the end of

Re: [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD

2015-01-21 Thread Hans de Goede
Hi, On 20-01-15 22:40, Tom Rini wrote: All of the code in arch/arm/cpu/armv7/sunxi/board.c was under a check for CONFIG_SPL_BUILD so instead only build for SPL. That is not true, the #ifdef SPL block ends at the end of board_init_f as things currently stand in master, and even that is only the

Re: [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD

2015-01-21 Thread Ian Campbell
On Tue, 2015-01-20 at 16:40 -0500, Tom Rini wrote: In general the change looks good, thanks. > -#if !defined CONFIG_SPL_BUILD && (defined CONFIG_MACH_SUN7I || \ > - defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I) > - /* Enable SMP mode for CPU0, by setting bit 6 of Auxilia

[U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD

2015-01-20 Thread Tom Rini
All of the code in arch/arm/cpu/armv7/sunxi/board.c was under a check for CONFIG_SPL_BUILD so instead only build for SPL. This lets us drop a hunk of code that was never enabled. Cc: Hans de Goede Cc: Ian Campbell Signed-off-by: Tom Rini --- arch/arm/cpu/armv7/sunxi/Makefile |2 +- arch/a