Re: [U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0

2017-02-27 Thread Anatolij Gustschin
On Fri, 24 Feb 2017 17:46:10 +0100 Jonathan Golder jonathan.gol...@kurz-elektronik.de wrote: > Passing NULL to fs_read() for actread value results in hanging U-Boot > at least on our ARM plattform (TI AM335x). Since fs_read() and > following functions do not catch nullpointers, writing to 0x0 occu

Re: [U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0

2017-02-27 Thread Igor Grinberg
Hi Jonathan, On 02/27/17 10:10, Jonathan Golder wrote: > Hi Igor, > >> I haven't looked at fs_read() yet, but from the above it seems that >> a better approach would be to fix the fs_read()? Might there be use >> cases when it is legitimate to pass NULL? > > > Well, actually I have not dived in

Re: [U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0

2017-02-26 Thread Igor Grinberg
Hi Jonathan, On 02/24/17 18:46, Jonathan Golder wrote: > Passing NULL to fs_read() for actread value results in hanging U-Boot > at least on our ARM plattform (TI AM335x). Since fs_read() and > following functions do not catch nullpointers, writing to 0x0 occurs. > > Passing a local dummy var ins

[U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0

2017-02-25 Thread Jonathan Golder
Passing NULL to fs_read() for actread value results in hanging U-Boot at least on our ARM plattform (TI AM335x). Since fs_read() and following functions do not catch nullpointers, writing to 0x0 occurs. Passing a local dummy var instead of NULL solves this issue. Signed-off-by: Jonathan Golder C