Re: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-20 Thread B, Ravi
Hi Lukasz >>> a/common/cli.c b/common/cli.c index a433ef2..3dd4c2b 100644 >>> --- a/common/cli.c >>> +++ b/common/cli.c >>> @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR; >>> */ >>> int run_command(const char *cmd, int flag) { -#ifndef >>> CONFIG_HUSH_PARSER >>> +#if defined(CONFIG_SPL_BUILD) ||

Re: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-19 Thread B, Ravi
Hi Lukasz >> >> diff --git a/common/Makefile b/common/Makefile index bcd2486..dc5cb1d >> 100644 >> --- a/common/Makefile >> +++ b/common/Makefile >> @@ -90,7 +90,6 @@ endif # !CONFIG_SPL_BUILD >> >> ifdef CONFIG_SPL_BUILD >> obj-$(CONFIG_SPL_DFU_SUPPORT) += dfu.o >> -obj-$(CONFIG_SPL_DFU_SUP

Re: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-19 Thread Lukasz Majewski
Hi Ravi, Please add u-boot mailing list to CC, when sending patches. > This patch fixes the compilation error > common/cli_hush.c:3349: undefined reference to 'realloc_simple' > > The dfu does not depend on HUSH_PARSER. > The dfu, fastboot uses run_command(), it is > part of cli.c and use cli_si

Re: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-19 Thread B, Ravi
Hi Lukasz >> diff --git a/common/cli.c b/common/cli.c index a433ef2..5e0869b 100644 >> --- a/common/cli.c >> +++ b/common/cli.c >> @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR; >> */ >> int run_command(const char *cmd, int flag) { -#ifndef >> CONFIG_HUSH_PARSER >> +#if defined(CONFIG_SPL_DFU_SUP

Re: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-18 Thread Lukasz Majewski
Hi Ravi, > This patch fixes the compilation error > common/cli_hush.c:3349: undefined reference to 'realloc_simple' > > The dfu uses run_command(), it is part of cli_hush.c > but defining CONFIG_HUSH_PARSER for spl-dfu causes > this compilation error. > > Signed-off-by: Ravi Babu > --- > commo

[U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

2017-04-18 Thread Ravi Babu
This patch fixes the compilation error common/cli_hush.c:3349: undefined reference to 'realloc_simple' The dfu uses run_command(), it is part of cli_hush.c but defining CONFIG_HUSH_PARSER for spl-dfu causes this compilation error. Signed-off-by: Ravi Babu --- common/cli.c | 2 +- 1 file changed