Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-28 Thread Thomas Chou
On 09/21/2015 08:58 PM, Thomas Chou wrote: Convert altera_spi to driver model Signed-off-by: Thomas Chou --- drivers/spi/Kconfig | 8 ++ drivers/spi/altera_spi.c | 197 ++- 2 files changed, 119 insertions(+), 86 deletions(-) Applied to

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-28 Thread Jagan Teki
On 28 September 2015 at 06:10, Thomas Chou wrote: > Hi Jagan, > > On 09/22/2015 02:01 AM, Jagan Teki wrote: >> >> On 21 September 2015 at 18:28, Thomas Chou wrote: >>> >>> Convert altera_spi to driver model >> >> >> Thanks for the patch, Thomas. >> >>> >>> Signed-off-by: Thomas Chou >> >> >> Rev

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-27 Thread Thomas Chou
Hi Jagan, On 09/22/2015 02:01 AM, Jagan Teki wrote: On 21 September 2015 at 18:28, Thomas Chou wrote: Convert altera_spi to driver model Thanks for the patch, Thomas. Signed-off-by: Thomas Chou Reviewed-by: Jagan Teki May I pick up this patch? As a custodian of the nios arch, I woul

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-22 Thread Marek Vasut
On Tuesday, September 22, 2015 at 09:45:22 AM, Thomas Chou wrote: > Hi Marek, Hi! > On 09/22/2015 12:13 PM, Marek Vasut wrote: > > I'm expecting that EPCQ Wundercontroller to have the same problem (see > > [1] section 42, Altera GQSPI). Altera tried to push this into mainline > > Linux even [2],

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-22 Thread Thomas Chou
Hi Marek, On 09/22/2015 12:13 PM, Marek Vasut wrote: I'm expecting that EPCQ Wundercontroller to have the same problem (see [1] section 42, Altera GQSPI). Altera tried to push this into mainline Linux even [2], without much success, in particular because they duplicated half of the spi-nor stack

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-21 Thread Marek Vasut
On Tuesday, September 22, 2015 at 05:52:58 AM, Thomas Chou wrote: > Hi Marek, Hi, > On 09/22/2015 08:10 AM, Marek Vasut wrote: > > I suspect you might want to tweak the core code to check if those > > .set_speed and .set_mode are assigned in dm_spi_ops structure and > > if not, don't call them. >

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-21 Thread Thomas Chou
Hi Marek, On 09/22/2015 08:10 AM, Marek Vasut wrote: I suspect you might want to tweak the core code to check if those .set_speed and .set_mode are assigned in dm_spi_ops structure and if not, don't call them. I wonder if this worths, as altera_spi is the only one that cannot set speed and mo

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-21 Thread Marek Vasut
On Monday, September 21, 2015 at 02:58:31 PM, Thomas Chou wrote: > Convert altera_spi to driver model > > Signed-off-by: Thomas Chou Hi! > --- > drivers/spi/Kconfig | 8 ++ > drivers/spi/altera_spi.c | 197 > ++- 2 files changed, 119 > insertio

Re: [U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-21 Thread Jagan Teki
On 21 September 2015 at 18:28, Thomas Chou wrote: > Convert altera_spi to driver model Thanks for the patch, Thomas. > > Signed-off-by: Thomas Chou Reviewed-by: Jagan Teki > --- > drivers/spi/Kconfig | 8 ++ > drivers/spi/altera_spi.c | 197 > ++--

[U-Boot] [PATCH] spi : convert altera_spi to driver model

2015-09-21 Thread Thomas Chou
Convert altera_spi to driver model Signed-off-by: Thomas Chou --- drivers/spi/Kconfig | 8 ++ drivers/spi/altera_spi.c | 197 ++- 2 files changed, 119 insertions(+), 86 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 8