Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Chin Liang See
Hi Gerhard, On Thu, 2013-12-19 at 21:03 +0100, Gerhard Sittig wrote: > On Thu, Dec 19, 2013 at 08:46 -0600, Chin Liang See wrote: > > > > Hi Gerhard, > > > > On Thu, 2013-12-19 at 14:50 +0100, Gerhard Sittig wrote: > > > On Wed, Dec 18, 2013 at 14:05 -0600, Chin Liang See wrote: > > > > > > > >

Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Gerhard Sittig
On Thu, Dec 19, 2013 at 08:46 -0600, Chin Liang See wrote: > > Hi Gerhard, > > On Thu, 2013-12-19 at 14:50 +0100, Gerhard Sittig wrote: > > On Wed, Dec 18, 2013 at 14:05 -0600, Chin Liang See wrote: > > > > > > To add the Cadence SPI driver support for Altera SOCFPGA. It > > > required informati

Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Chin Liang See
Hi Jagan, On Thu, 2013-12-19 at 21:39 +0530, Jagan Teki wrote: > Thanks for your patch. > > Please see the typical driver code suggestions on below thread. > http://u-boot.10912.n7.nabble.com/Suggestions-for-SPI-driver-pusher-td161008.html > > Try to avoid the header files make sure to code ever

Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Jagan Teki
Thanks for your patch. Please see the typical driver code suggestions on below thread. http://u-boot.10912.n7.nabble.com/Suggestions-for-SPI-driver-pusher-td161008.html Try to avoid the header files make sure to code everything in single .c file. Also add some documents as well as test log on do

Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Chin Liang See
Hi Gerhard, On Thu, 2013-12-19 at 14:50 +0100, Gerhard Sittig wrote: > On Wed, Dec 18, 2013 at 14:05 -0600, Chin Liang See wrote: > > > > To add the Cadence SPI driver support for Altera SOCFPGA. It > > required information such as clocks and timing from platform's > > configuration header file w

Re: [U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-19 Thread Gerhard Sittig
On Wed, Dec 18, 2013 at 14:05 -0600, Chin Liang See wrote: > > To add the Cadence SPI driver support for Altera SOCFPGA. It > required information such as clocks and timing from platform's > configuration header file within include/configs folder > > Signed-off-by: Chin Liang See > Cc: Jagannadh

[U-Boot] [PATCH] spi/cadence: Adding Cadence SPI driver support for SOCFPGA

2013-12-18 Thread Chin Liang See
To add the Cadence SPI driver support for Altera SOCFPGA. It required information such as clocks and timing from platform's configuration header file within include/configs folder Signed-off-by: Chin Liang See Cc: Jagannadha Sutradharudu Teki --- drivers/spi/Makefile |1 + drivers