Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-04-24 Thread Heiko Schocher
Hello Nobuhiro, Nobuhiro Iwamatsu wrote: > Renesas SH7734 has two I2C interfaceis. > This supports these I2C. > > V5: - include i2c.h. > - Add check of icsr bit polling logic. > - Implement i2c_probe. > V4: - Remove sh_i2c_dump_reg function. > - Use puts() when there's no format. >

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-03-01 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-03-01 Thread Nobuhiro Iwamatsu
Renesas SH7734 has two I2C interfaceis. This supports these I2C. V5: - include i2c.h. - Add check of icsr bit polling logic. - Implement i2c_probe. V4: - Remove sh_i2c_dump_reg function. - Use puts() when there's no format. - Chnage check for I2C bus number. - Remove space

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-29 Thread Nobuhiro Iwamatsu
Hi, Mike. Thank you for your review. 2012/2/22 Mike Frysinger : > On Tuesday 21 February 2012 20:13:47 Nobuhiro Iwamatsu wrote: >> --- /dev/null >> +++ b/drivers/i2c/sh_sh7734_i2c.c >> >> +#if DEBUG >> +static void sh_i2c_dump_reg(struct sh_i2c *base) >> +{ >> +     printf("iccr1 : %02X\n", readb

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-22 Thread Mike Frysinger
On Wednesday 22 February 2012 08:53:50 Marek Vasut wrote: > > On Tuesday 21 February 2012 20:13:47 Nobuhiro Iwamatsu wrote: > > > --- /dev/null > > > +++ b/drivers/i2c/sh_sh7734_i2c.c > > > > > > +#if DEBUG > > > +static void sh_i2c_dump_reg(struct sh_i2c *base) > > > +{ > > > + printf("iccr1 : %0

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-22 Thread Marek Vasut
> On Tuesday 21 February 2012 20:13:47 Nobuhiro Iwamatsu wrote: > > --- /dev/null > > +++ b/drivers/i2c/sh_sh7734_i2c.c > > > > +#if DEBUG > > +static void sh_i2c_dump_reg(struct sh_i2c *base) > > +{ > > + printf("iccr1 : %02X\n", readb(&base->iccr1)); > > + printf("iccr2 : %02X\n", readb(&bas

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-21 Thread Mike Frysinger
On Tuesday 21 February 2012 20:13:47 Nobuhiro Iwamatsu wrote: > --- /dev/null > +++ b/drivers/i2c/sh_sh7734_i2c.c > > +#if DEBUG > +static void sh_i2c_dump_reg(struct sh_i2c *base) > +{ > + printf("iccr1 : %02X\n", readb(&base->iccr1)); > + printf("iccr2 : %02X\n", readb(&base->iccr2)); > +

[U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-21 Thread Nobuhiro Iwamatsu
Renesas SH7734 has two I2C interfaceis. This supports these I2C. V3: - Fix error for whitespace. V2: - Changed bit control to use the clr|set|clrsetbits_* functions. - Fix wrong comment style. - Add new line before for loop in i2c_read. Signed-off-by: Nobuhiro Iwamatsu Acked-by: Heiko Sc

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-14 Thread Nobuhiro Iwamatsu
Hi, Thanks for your comment. 2012/2/6 Heiko Schocher : > Hello Nobuhiro, > > Nobuhiro Iwamatsu wrote: >> Renesas SH7734 has two I2C interfaceis. >> This supports these I2C. >> >> Signed-off-by: Nobuhiro Iwamatsu >> --- >>  drivers/i2c/Makefile        |    1 + >>  drivers/i2c/sh_sh7734_i2c.c |  4

Re: [U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-05 Thread Heiko Schocher
Hello Nobuhiro, Nobuhiro Iwamatsu wrote: > Renesas SH7734 has two I2C interfaceis. > This supports these I2C. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/i2c/Makefile|1 + > drivers/i2c/sh_sh7734_i2c.c | 468 > +++ > 2 files changed

[U-Boot] [PATCH] sh: i2c: Add support I2C controller of SH7734

2012-02-02 Thread Nobuhiro Iwamatsu
Renesas SH7734 has two I2C interfaceis. This supports these I2C. Signed-off-by: Nobuhiro Iwamatsu --- drivers/i2c/Makefile|1 + drivers/i2c/sh_sh7734_i2c.c | 468 +++ 2 files changed, 469 insertions(+), 0 deletions(-) create mode 100644 drive