Re: [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed

2015-05-13 Thread Daniel Thompson
On 12/05/15 22:56, Tom Rini wrote: On Tue, May 12, 2015 at 10:35:55PM +0200, Kamil Lulko wrote: Strange, this was already posted by Kunhua Huang - then reverted in commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this carriage return should be added there. I simply forgot it since I

Re: [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed

2015-05-12 Thread Kunhua Huang
On Tue, May 12, 2015 at 05:56:36PM -0400, Tom Rini wrote: > On Tue, May 12, 2015 at 10:35:55PM +0200, Kamil Lulko wrote: > > > Strange, this was already posted by Kunhua Huang - then reverted in > > commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this > > carriage return should be adde

Re: [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed

2015-05-12 Thread Tom Rini
On Tue, May 12, 2015 at 10:35:55PM +0200, Kamil Lulko wrote: > Strange, this was already posted by Kunhua Huang - then reverted in > commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this > carriage return should be added there. I simply forgot it since I had > implicit CR for each LF t

Re: [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed

2015-05-12 Thread Kamil Lulko
Strange, this was already posted by Kunhua Huang - then reverted in commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this carriage return should be added there. I simply forgot it since I had implicit CR for each LF turned on in my terminal. Never thought this would cause so much havoc

[U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed

2015-05-12 Thread Daniel Thompson
Currently the u-boot output looks rather odd when running the minicom terminal emulator in its default mode (just a string of "random" looking text down the right hand side of the screen). This is caused by a combination of minicom not automatically wrapping lines and the stm32 serial driver never