Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-18 Thread Lokesh Vutla
nder Graf [mailto:ag...@suse.de] >>>> Sent: Tuesday, July 17, 2018 4:33 PM >>>> To: Tom Rini >>>> Cc: Wolfgang Denk ; Felix Brack ; >>>> u-boot@lists.denx.de; Stefan Roese ; Alexey Brodkin >>>> ; Michal Simek >>>> Subject: Re: [U

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Andy Shevchenko
On Wed, Jul 18, 2018 at 12:30 AM, Adam Ford wrote: > On Tue, Jul 17, 2018 at 4:24 PM Andy Shevchenko > wrote: >> https://elixir.bootlin.com/linux/v4.18-rc5/source/drivers/tty/serial/8250/8250_omap.c > Can we omap2+ users patch the 8250_omap.c code in Linux to make use of > the reg-shift, then d

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Adam Ford
On Tue, Jul 17, 2018 at 4:24 PM Andy Shevchenko wrote: > > On Tue, Jul 17, 2018 at 4:34 PM, Alexey Brodkin > wrote: > > >> Linux has a completely separate driver for omap3 (which is wrong too). > > This is not (fully) correct, > > >> But in a nutshell, it basically determines the shift value by t

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Andy Shevchenko
On Tue, Jul 17, 2018 at 4:34 PM, Alexey Brodkin wrote: >> Linux has a completely separate driver for omap3 (which is wrong too). This is not (fully) correct, >> But in a nutshell, it basically determines the shift value by the >> "compatible" string, so we should too. > > Here's the driver: > h

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Alexander Graf
@lists.denx.de; Stefan Roese ; Alexey Brodkin ; Michal Simek Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable On 07/17/2018 03:25 PM, Tom Rini wrote: On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alexander Graf wrote: On 07/14/2018 05:49 PM, Tom Rini wrote: On Sat, Jul 14, 2018

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Tom Rini
; > > u-boot@lists.denx.de; Stefan Roese ; Alexey Brodkin > > ; Michal Simek > > Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable > > > > On 07/17/2018 03:25 PM, Tom Rini wrote: > > > On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alex

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Tom Rini
On Tue, Jul 17, 2018 at 03:33:15PM +0200, Alexander Graf wrote: > On 07/17/2018 03:25 PM, Tom Rini wrote: > >On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alexander Graf wrote: > >>On 07/14/2018 05:49 PM, Tom Rini wrote: > >>>On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: > Dear Fel

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Alexander Graf
; Alexander Graf ; Michal Simek ; Wolfgang Denk Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable Hi Alexey, On 15.07.2018 10:43, Alexey Brodkin wrote: Hi Tom, Felix, all -Original Message- From: Tom Rini [mailto:tr...@konsulko.com] Sent: Saturday, July 14, 2018 6:50

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Alexey Brodkin
[U-Boot] [PATCH] serial: ns16550: Add register shift variable > > On 07/17/2018 03:25 PM, Tom Rini wrote: > > On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alexander Graf wrote: > >> On 07/14/2018 05:49 PM, Tom Rini wrote: > >>> On Sat, Jul 14, 2018 at 12:47:21PM +0200,

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Alexander Graf
On 07/17/2018 03:25 PM, Tom Rini wrote: On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alexander Graf wrote: On 07/14/2018 05:49 PM, Tom Rini wrote: On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: Dear Felix, In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: The

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Tom Rini
On Mon, Jul 16, 2018 at 02:53:26PM +0200, Alexander Graf wrote: > On 07/14/2018 05:49 PM, Tom Rini wrote: > >On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: > >>Dear Felix, > >> > >>In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: > >>>The motivation for writing t

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-17 Thread Tom Rini
On Mon, Jul 16, 2018 at 06:47:21PM +0300, Andy Shevchenko wrote: > On Mon, Jul 16, 2018 at 6:04 PM, Alexey Brodkin > wrote: > > >> > Any chance to get a reference to the commit in Linux kernel that > >> > introduces that change? > >> > > >> In fact I believe that the property never existed in t

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Felix Brack
Stefan Roese ; Alexander Graf >> ; Michal Simek ; >> Wolfgang Denk >> Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable >> >> Hi Alexey, >> >> On 15.07.2018 10:43, Alexey Brodkin wrote: >>> Hi Tom, Felix, all >>> >

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Andy Shevchenko
On Mon, Jul 16, 2018 at 6:04 PM, Alexey Brodkin wrote: >> > Any chance to get a reference to the commit in Linux kernel that >> > introduces that change? >> > >> In fact I believe that the property never existed in the >> am33xx.dtsi file from Linux. U-Boot commit 85cf0e6299 shows that the >> p

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Alexey Brodkin
y, July 14, 2018 6:50 PM > >> To: Wolfgang Denk > >> Cc: Felix Brack ; u-boot@lists.denx.de; Stefan Roese > >> ; Alexey Brodkin ; > >> Alexander Graf ; Michal Simek > >> Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable > >&

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Alexander Graf
On 07/14/2018 05:49 PM, Tom Rini wrote: On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: Dear Felix, In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: The motivation for writing this patch originates in the effort of synchronizing U-Boot DT to Linux DT for am33

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Felix Brack
On 16.07.2018 14:42, Wolfgang Denk wrote: > Dear Felix, > > In message <1b0d33fa-adfb-9825-5ae8-8bded1678...@ltec.ch> you wrote: >> This needs to be rewritten. >>> >>> To try and help clarify, the property in question means "quantity to >>> shift the register offsets by." It should be clear

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-16 Thread Wolfgang Denk
Dear Felix, In message <1b0d33fa-adfb-9825-5ae8-8bded1678...@ltec.ch> you wrote: > > >> This needs to be rewritten. > > > > To try and help clarify, the property in question means "quantity to > > shift the register offsets by." It should be clear in our Kconfig help > > entry as well that this

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-15 Thread Felix Brack
e; Stefan Roese >> ; Alexey Brodkin ; >> Alexander Graf ; Michal Simek >> Subject: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable >> >> On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: >>> Dear Felix, >>> >>>

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-15 Thread Felix Brack
Hi Tom, On 14.07.2018 17:49, Tom Rini wrote: > On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: >> Dear Felix, >> >> In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: >>> >>> The motivation for writing this patch originates in the >>> effort of synchronizing U-Boot

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-15 Thread Felix Brack
Hello Wolfgang, On 14.07.2018 12:47, Wolfgang Denk wrote: > Dear Felix, > > In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: >> >> The motivation for writing this patch originates in the >> effort of synchronizing U-Boot DT to Linux DT for am33xx SOCs. >> The current am33xx.dt

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-15 Thread Alexey Brodkin
ect: Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable > > On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: > > Dear Felix, > > > > In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: > > > > > >

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-14 Thread Tom Rini
On Sat, Jul 14, 2018 at 12:47:21PM +0200, Wolfgang Denk wrote: > Dear Felix, > > In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: > > > > The motivation for writing this patch originates in the > > effort of synchronizing U-Boot DT to Linux DT for am33xx SOCs. > > The current a

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-14 Thread Wolfgang Denk
Dear Felix, In message <1531492980-16543-1-git-send-email...@ltec.ch> you wrote: > > The motivation for writing this patch originates in the > effort of synchronizing U-Boot DT to Linux DT for am33xx SOCs. > The current am33xx.dtsi file from U-Boot defines the > property for all UART nodes. The a

Re: [U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-13 Thread Alexander Graf
On 07/13/2018 04:43 PM, Felix Brack wrote: This patch adds a new Kconfig variable that allows setting the register shift value for the ns16550 driver to some other value then 0 if not defined by the DT. All credit for this patch goes to Lokesh Vutla as it was his idea. The motivation for writing

[U-Boot] [PATCH] serial: ns16550: Add register shift variable

2018-07-13 Thread Felix Brack
This patch adds a new Kconfig variable that allows setting the register shift value for the ns16550 driver to some other value then 0 if not defined by the DT. All credit for this patch goes to Lokesh Vutla as it was his idea. The motivation for writing this patch originates in the effort of synch