Re: [U-Boot] [PATCH] sandbox: Fix comparison of unsigned enum expression warning

2017-06-06 Thread sjg
On 13 May 2017 at 18:11, Tom Rini wrote: > In os_dirent_get_typename() we are checking that type falls within the > known values of the enum os_dirent_t. With clang-3.8 testing this value > as being >= 0 results in a warning as it will always be true. This > assumes of course that we are only gi

Re: [U-Boot] [PATCH] sandbox: Fix comparison of unsigned enum expression warning

2017-05-14 Thread Simon Glass
On 13 May 2017 at 18:11, Tom Rini wrote: > In os_dirent_get_typename() we are checking that type falls within the > known values of the enum os_dirent_t. With clang-3.8 testing this value > as being >= 0 results in a warning as it will always be true. This > assumes of course that we are only gi

[U-Boot] [PATCH] sandbox: Fix comparison of unsigned enum expression warning

2017-05-13 Thread Tom Rini
In os_dirent_get_typename() we are checking that type falls within the known values of the enum os_dirent_t. With clang-3.8 testing this value as being >= 0 results in a warning as it will always be true. This assumes of course that we are only given valid data. Given that we want to sanity chec