Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2011-01-20 Thread Albert ARIBAUD
Le 18/12/2010 13:08, Jens Scharsig a écrit : > * remove LED initialization in front of relocation and bss init > > Signed-off-by: Jens Scharsig > --- > > * prevents run C function on an uninitialized environment > > arch/arm/cpu/arm920t/start.S |3 --- > 1 files changed, 0 insertions(+), 3

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Jens Scharsig
To explain the background 1st: I've compiled my code for easier debugging without -Os option. But the non optimized code needs a valid stack at this position. It's only as secondary problem 2nd: The functions will called later again. 3rd: Some soc are not fully intitialized here (e.g Clock as

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4d134c08.8090...@emk-elektronik.de> you wrote: > > > Keep the existing code, and just turn the current set of numbers into > > an enum. > > What current code? I meant the existing show_boot_progress() code. > 1. show_boot_progress() is quite close, but has hundr

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Reinhard Meyer
Dear Wolfgang Denk, > Dear Reinhard Meyer, > > In message<4d1340bd.2090...@emk-elektronik.de> you wrote: >> >> We should have one function like "show_status(int status)" >> with various statuses defined like: >> LED_STATUS_RESET, _BEFORE_RELOC, _AFTER_RELOC, _SENT_DHCP, _STARTING_KERNEL, >> _CRASH

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4d1340bd.2090...@emk-elektronik.de> you wrote: > > We should have one function like "show_status(int status)" > with various statuses defined like: > LED_STATUS_RESET, _BEFORE_RELOC, _AFTER_RELOC, _SENT_DHCP, _STARTING_KERNEL, > _CRASHED, ... Keep the existing cod

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Reinhard Meyer
On 23.12.2010 12:58, Andreas Bießmann wrote: > Dear Jens Scharsig, > > Am 18.12.2010 um 13:08 schrieb Jens Scharsig: > >> * remove LED initialization in front of relocation and bss init >> >> Signed-off-by: Jens Scharsig >> --- >> >> * prevents run C function on an uninitialized environment > > You

Re: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-23 Thread Andreas Bießmann
Dear Jens Scharsig, Am 18.12.2010 um 13:08 schrieb Jens Scharsig: > * remove LED initialization in front of relocation and bss init > > Signed-off-by: Jens Scharsig > --- > > * prevents run C function on an uninitialized environment You are right, we do not have stack/bss setup when we call t

[U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

2010-12-18 Thread Jens Scharsig
* remove LED initialization in front of relocation and bss init Signed-off-by: Jens Scharsig --- * prevents run C function on an uninitialized environment arch/arm/cpu/arm920t/start.S |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/arm920t/start.S b/ar