Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-30 Thread Stefan Roese
On Monday 29 March 2010 15:35:43 Stefan Roese wrote: > This patch fixes a problem introduced with patch eb5eb2b0 > [ppc4xx: Cleanup PPC4xx I2C infrastructure]. We need to assign the I2C > base address to the "i2c" pointer inside of the controller loop. > Otherwise controller 0 is initialized multip

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Stefan Roese
On Monday 29 March 2010 16:56:32 Heiko Schocher wrote: > >> Ah, I just wanted to send a pull request to Wolfgang, because I added > >> it to i2c next ... is this Ok for you? > > > > It's supposed to go into "master" (bug fix). So if you plan to push it > > via your master branch, then it's fine wi

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Heiko Schocher
Hello Stefan, Stefan Roese wrote: > On Monday 29 March 2010 15:57:22 Heiko Schocher wrote: > Please let me know if you see any problems with this patch. I would > really like to push it into this release, since it really is a bug > fix. It looks Ok for me. >>> Good. If nobody else

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Stefan Roese
Hi Heiko, On Monday 29 March 2010 15:57:22 Heiko Schocher wrote: > >>> Please let me know if you see any problems with this patch. I would > >>> really like to push it into this release, since it really is a bug > >>> fix. > >> > >> It looks Ok for me. > > > > Good. If nobody else objects, I'll

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Heiko Schocher
Hello Stefan, Stefan Roese wrote: > On Monday 29 March 2010 15:43:50 Heiko Schocher wrote: >>> Heiko, I just noticed that this PPC4xx I2C driver is still in the >>> cpu/ppc4xx directory. I suggest that we move it into drivers/i2c >>> after the next release. Is this ok for you? I can provide a patc

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Stefan Roese
Hi Heiko, On Monday 29 March 2010 15:43:50 Heiko Schocher wrote: > > Heiko, I just noticed that this PPC4xx I2C driver is still in the > > cpu/ppc4xx directory. I suggest that we move it into drivers/i2c > > after the next release. Is this ok for you? I can provide a patch > > for this soon. > >

Re: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Heiko Schocher
Hello Stefan, Stefan Roese wrote: > This patch fixes a problem introduced with patch eb5eb2b0 > [ppc4xx: Cleanup PPC4xx I2C infrastructure]. We need to assign the I2C > base address to the "i2c" pointer inside of the controller loop. > Otherwise controller 0 is initialized multiple times instead o

[U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization

2010-03-29 Thread Stefan Roese
This patch fixes a problem introduced with patch eb5eb2b0 [ppc4xx: Cleanup PPC4xx I2C infrastructure]. We need to assign the I2C base address to the "i2c" pointer inside of the controller loop. Otherwise controller 0 is initialized multiple times instead of initializing each I2C controller sequenti