Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-18 Thread Stefan Roese
Hi Matthias, On Wednesday 18 February 2009, Stefan Roese wrote: > On Sunday 15 February 2009, Matthias Fuchs wrote: > > This patch fixes coding style for PMC405 board support. > > Also some unneeded features/code is removed. > > Applied to ppc4xx/master. Thanks. After applying I noticed still som

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-18 Thread Stefan Roese
On Sunday 15 February 2009, Matthias Fuchs wrote: > This patch fixes coding style for PMC405 board support. > Also some unneeded features/code is removed. Applied to ppc4xx/master. Thanks. Best regards, Stefan = DENX Software En

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-18 Thread Stefan Roese
On Wednesday 18 February 2009, Matthias Fuchs wrote: > > > I suggest to switch to using the out_be32()/in_be32() accessor > > > functions instead. I am aware that many other 4xx boards still use the > > > "wrong" accessor functions for initial GPIO configuration. I'll try to > > > change this soon.

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-17 Thread Matthias Fuchs
Hi Stefan, > On Tuesday 17 February 2009 15:19, Stefan Roese wrote: > > On Sunday 15 February 2009, Matthias Fuchs wrote: > > > This patch fixes coding style for PMC405 board support. > > > Also some unneeded features/code is removed. > > > > Please find some comments below. > > > > > + out32(GPI

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-17 Thread Matthias Fuchs
On Tuesday 17 February 2009 15:19, Stefan Roese wrote: > On Sunday 15 February 2009, Matthias Fuchs wrote: > > This patch fixes coding style for PMC405 board support. > > Also some unneeded features/code is removed. > > Please find some comments below. > > > Signed-off-by: Matthias Fuchs > > ---

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-17 Thread Stefan Roese
On Tuesday 17 February 2009, Matthias Fuchs wrote: > > I suggest to switch to using the out_be32()/in_be32() accessor functions > > instead. I am aware that many other 4xx boards still use the "wrong" > > accessor functions for initial GPIO configuration. I'll try to change > > this soon. > > You a

Re: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-17 Thread Stefan Roese
On Sunday 15 February 2009, Matthias Fuchs wrote: > This patch fixes coding style for PMC405 board support. > Also some unneeded features/code is removed. Please find some comments below. > Signed-off-by: Matthias Fuchs > --- > board/esd/pmc405/pmc405.c | 95 --- > include/configs

[U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support

2009-02-15 Thread Matthias Fuchs
This patch fixes coding style for PMC405 board support. Also some unneeded features/code is removed. Signed-off-by: Matthias Fuchs --- board/esd/pmc405/pmc405.c | 95 --- include/configs/PMC405.h | 285 ++--- 2 files changed, 165 insertions