Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-28 Thread Detlev Zundel
Hi Feng, [general remark - isn't it possible that you quote mails "the regular way"[1]? I'm having a hard time to distinguish the new text from the original text]. > On Fri, Sep 24, 2010 at 10:43 AM, Wolfgang Denk wrote: >> Dear Feng Kan, >> >> In message >> you wrote: >>> >>> FKAN: Dear Wolf

Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-24 Thread Feng Kan
On Fri, Sep 24, 2010 at 10:43 AM, Wolfgang Denk wrote: > Dear Feng Kan, > > In message you > wrote: >> >> FKAN: Dear Wolfgang, is the symmetry needed here? If a user >> plan to use the usb, he will trigger the function. Otherwise, on >> a stop what value would we put it back to. > > Design rules

Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-24 Thread Wolfgang Denk
Dear Feng Kan, In message you wrote: > > FKAN: Dear Wolfgang, is the symmetry needed here? If a user > plan to use the usb, he will trigger the function. Otherwise, on > a stop what value would we put it back to. Design rules say: Shall initialize only such peripherals used by U-Boot i

Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-24 Thread Feng Kan
> > Also, when adding this code to usb_board_init(), would it not be > logical to undo this initialization in usb_board_stop()? > > RUP >> Ok, I will include your suggestion and resubmit > FKAN: Dear Wolfgang, is the symmetry needed here? If a user plan to use the usb, he will trigger the function

Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-24 Thread Rupjyoti Sarmah
Hello Wolfgang, > So moved the reconfiguration to the USB init function Does the Linux kernel perform the same initiaalization of the GPIO pins? If not, then your change will most likely cause the USB is not working in Linux unless you used USB in U-Boot. RUP >> Yes, it does. > --- a/board/a

Re: [U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-23 Thread Wolfgang Denk
Dear Rupjyoti Sarmah, In message <201009231421.o8neloe9022...@amcc.com> you wrote: > > The GPIO 16 and 19 reconfiguration should be done once USB is initialized. > So moved the reconfiguration to the USB init function Does the Linux kernel perform the same initiaalization of the GPIO pins? If

[U-Boot] [PATCH] ppc44x: config GPIOs for USB on canyonlands board

2010-09-23 Thread Rupjyoti Sarmah
The GPIO 16 and 19 reconfiguration should be done once USB is initialized. So moved the reconfiguration to the USB init function Signed-off-by: Rupjyoti Sarmah --- board/amcc/canyonlands/canyonlands.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/