Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-24 Thread Kumar Gala
On May 24, 2010, at 1:19 PM, Timur Tabi wrote: > On Mon, May 24, 2010 at 1:12 PM, Kumar Gala wrote: > +} pixis_t __attribute__ ((aligned(1))); >>> >>> What's the aligned(1) for? >> >> Asked Timur, I copied it from the ngpixis.h header > > Hmmm... I think I might have meant __packed__ i

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-24 Thread Timur Tabi
On Mon, May 24, 2010 at 1:12 PM, Kumar Gala wrote: >>> +} pixis_t  __attribute__ ((aligned(1))); >> >> What's the aligned(1) for? > > Asked Timur, I copied it from the ngpixis.h header Hmmm... I think I might have meant __packed__ instead of aligned(1). -- Timur Tabi Linux kernel developer at

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-24 Thread Kumar Gala
On May 24, 2010, at 11:23 AM, Scott Wood wrote: > On Sat, May 22, 2010 at 05:33:31PM -0500, Kumar Gala wrote: >> +/* PIXIS register set. */ >> +#if defined(CONFIG_MPC8536DS) >> +typedef struct pixis { >> +u8 id; >> +u8 ver; >> +u8 pver; >> +u8 csr; >> +u8 rst; >> +u8 rst2;

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-24 Thread Scott Wood
On Sat, May 22, 2010 at 05:33:31PM -0500, Kumar Gala wrote: > +/* PIXIS register set. */ > +#if defined(CONFIG_MPC8536DS) > +typedef struct pixis { > + u8 id; > + u8 ver; > + u8 pver; > + u8 csr; > + u8 rst; > + u8 rst2; > + u8 aux1; > + u8 spd; > + u8 aux2; > +

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-23 Thread Kumar Gala
On May 23, 2010, at 1:32 PM, Timur Tabi wrote: > On Sat, May 22, 2010 at 5:33 PM, Kumar Gala wrote: >> +#if defined(CONFIG_MPC8536DS) >> +typedef struct pixis { >> + u8 id; >> + u8 ver; >> + u8 pver; >> + u8 csr; >> + u8 rst; >> + u8 rst2; >> + u8 aux1;

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-23 Thread Timur Tabi
On Sat, May 22, 2010 at 5:33 PM, Kumar Gala wrote: > +#if defined(CONFIG_MPC8536DS) > +typedef struct pixis { > +       u8 id; > +       u8 ver; > +       u8 pver; > +       u8 csr; > +       u8 rst; > +       u8 rst2; > +       u8 aux1; > +       u8 spd; > + u8 aux2; > + u8 csr2; > +

[U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-22 Thread Kumar Gala
The various boards that have PIXIS FPGAs have slightly different register definitions, however there is some common functionality (like reset, ICS307 clk control, etc) that can be shared. The struct definition exists for MPC8536DS, MPC8544DS, MPC8572DS, MPC8610HPCD, and MPC8641HPCN boards. Signed