Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-21 Thread Liu Shengzhou-B36685
> -Original Message- > From: Andy Fleming [mailto:aflem...@gmail.com] > Sent: Saturday, October 20, 2012 5:22 AM > To: Marek Vasut > Cc: Liu Shengzhou-B36685; u-boot@lists.denx.de; Stefan Roese > Subject: Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when >

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-21 Thread Liu Shengzhou-B36685
> -Original Message- > From: Anatolij Gustschin [mailto:ag...@denx.de] > Sent: Saturday, October 20, 2012 4:14 AM > To: Liu Shengzhou-B36685 > Cc: Marek Vasut; u-boot@lists.denx.de; Stefan Roese > Subject: Re: [PATCH] powerpc/usb: fix bug of CPU hang when missing USB > PHY clock > > you m

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-19 Thread Andy Fleming
On Thu, Oct 18, 2012 at 4:04 AM, Marek Vasut wrote: > Dear Liu Shengzhou-B36685, >> > > > >> > > > > +/* Check USB PHY clock valid */ >> > > > > +static int usb_phy_clk_valid(struct usb_ehci *ehci) { >> > > > > + if ((!(in_be32(&ehci->control) & PHY_CLK_VALID)) && >> > > > > +

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-19 Thread Anatolij Gustschin
Hi, On Thu, 18 Oct 2012 06:21:56 +0200 Marek Vasut wrote: > Dear Shengzhou Liu, > > > when missing USB PHY clock, u-boot will hang during USB > > initialization when issuing "usb start". We should check > > USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. > > > > Signed-off-by: Shen

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-18 Thread Marek Vasut
Dear Liu Shengzhou-B36685, > > -Original Message- > > From: Marek Vasut [mailto:ma...@denx.de] > > Sent: Thursday, October 18, 2012 3:16 PM > > To: Liu Shengzhou-B36685 > > Cc: u-boot@lists.denx.de; Stefan Roese; ag...@denx.de > > Subject: Re: [PATCH] powerpc/usb: fix bug of CPU hang when

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-18 Thread Liu Shengzhou-B36685
> -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: Thursday, October 18, 2012 3:16 PM > To: Liu Shengzhou-B36685 > Cc: u-boot@lists.denx.de; Stefan Roese; ag...@denx.de > Subject: Re: [PATCH] powerpc/usb: fix bug of CPU hang when missing USB > PHY clock > > Dear Liu

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-18 Thread Marek Vasut
Dear Liu Shengzhou-B36685, > > -Original Message- > > > > > +/* Check USB PHY clock valid */ > > > +static int usb_phy_clk_valid(struct usb_ehci *ehci) { > > > + if ((!(in_be32(&ehci->control) & PHY_CLK_VALID)) && > > > + (!in_be32(&ehci->prictrl))) { > > > > (!A && !B) c

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-17 Thread Liu Shengzhou-B36685
> -Original Message- > > > > +/* Check USB PHY clock valid */ > > +static int usb_phy_clk_valid(struct usb_ehci *ehci) { > > + if ((!(in_be32(&ehci->control) & PHY_CLK_VALID)) && > > + (!in_be32(&ehci->prictrl))) { > > (!A && !B) condition can certainly be done without

Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-17 Thread Marek Vasut
Dear Shengzhou Liu, > when missing USB PHY clock, u-boot will hang during USB > initialization when issuing "usb start". We should check > USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. > > Signed-off-by: Shengzhou Liu CCing PPC experts. > --- > against master branch of upstream u

[U-Boot] [PATCH] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-10-17 Thread Shengzhou Liu
when missing USB PHY clock, u-boot will hang during USB initialization when issuing "usb start". We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. Signed-off-by: Shengzhou Liu --- against master branch of upstream u-boot tree drivers/usb/host/ehci-fsl.c | 22