Re: [U-Boot] [PATCH] powerpc/mpc85xx: Make NMG_CPU_A011 workaround conditional

2012-08-09 Thread Wolfgang Denk
Dear York Sun, In message <1344467781.18960.41.camel@oslab-l1> you wrote: > > If the buffer isn't big enough, getenv_f() will print a message saying ... but only if it can (i. e. if he call is _after_ the initialization of the console driver has been completed (which is actually pretty late). Be

Re: [U-Boot] [PATCH] powerpc/mpc85xx: Make NMG_CPU_A011 workaround conditional

2012-08-08 Thread Andy Fleming
On Wed, Aug 8, 2012 at 6:16 PM, York Sun wrote: > On Wed, 2012-08-08 at 15:09 -0500, Andy Fleming wrote: >> Please copy me on any 85xx U-Boot patches. >> >> >> > >> > +#define HWCONFIG_BUFFER_SIZE 128 >> >> >> [...] >> >> > + char buffer[HWCONFIG_BUFFER_SIZE]; >> > + char *buf = NULL;

Re: [U-Boot] [PATCH] powerpc/mpc85xx: Make NMG_CPU_A011 workaround conditional

2012-08-08 Thread York Sun
On Wed, 2012-08-08 at 15:09 -0500, Andy Fleming wrote: > Please copy me on any 85xx U-Boot patches. > > > > > > +#define HWCONFIG_BUFFER_SIZE 128 > > > [...] > > > + char buffer[HWCONFIG_BUFFER_SIZE]; > > + char *buf = NULL; > > + > > + if (getenv_f("hwconfig", buffer, sizeof

Re: [U-Boot] [PATCH] powerpc/mpc85xx: Make NMG_CPU_A011 workaround conditional

2012-08-08 Thread Andy Fleming
Please copy me on any 85xx U-Boot patches. > > +#define HWCONFIG_BUFFER_SIZE 128 [...] > + char buffer[HWCONFIG_BUFFER_SIZE]; > + char *buf = NULL; > + > + if (getenv_f("hwconfig", buffer, sizeof(buffer)) > 0) > + buf = buffer; This seems fragile. I suppose th

[U-Boot] [PATCH] powerpc/mpc85xx: Make NMG_CPU_A011 workaround conditional

2012-05-18 Thread York Sun
Workaround for erratum NMG_CPU_A011 can be enabled by hwconfig with syntax fsl_cpu_a011:enable This workaround is not enabled by default. Enabling this workaround may degrade performance. P4080 erratum CPU22 shares the same workaround. So it is always enabled for P4080. Signed-off-by: York Sun