Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-17 Thread Tom Rini
On Mon, Oct 17, 2016 at 08:03:23PM +0300, Nicolae Rosia wrote: > Hi, > > On Sat, Oct 15, 2016 at 8:48 PM, Tom Rini wrote: > > I'll take this and do you want to do a follow up to make the file > > checkpatch clean? Thanks! > Either way works for me, I can do the follow up to make the file > check

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-17 Thread Nicolae Rosia
Hi, On Sat, Oct 15, 2016 at 8:48 PM, Tom Rini wrote: > I'll take this and do you want to do a follow up to make the file > checkpatch clean? Thanks! Either way works for me, I can do the follow up to make the file checkpatch clean. Thanks, Nicolae ___

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-15 Thread Paul Kocialkowski
Hi, Le samedi 15 octobre 2016 à 20:41 +0300, Nicolae Rosia a écrit : > Hi, > > On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski wrote: > > > > Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit : > > > > > > From: Nicolae Rosia > > > > > > Commit a85362fb3e1fc7833723accddbbae431

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-15 Thread Tom Rini
On Sat, Oct 15, 2016 at 08:41:35PM +0300, Nicolae Rosia wrote: > Hi, > > On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski wrote: > > Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit : > >> From: Nicolae Rosia > >> > >> Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-15 Thread Nicolae Rosia
Hi, On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski wrote: > Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit : >> From: Nicolae Rosia >> >> Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code >> but the register read ended up in the wrong if branch. >> Currently,

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-14 Thread Paul Kocialkowski
Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit : > From: Nicolae Rosia > > Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code > but the register read ended up in the wrong if branch. > Currently, the else branch checks a variable which is always 0. Good catch! Sor

Re: [U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-13 Thread Tom Rini
On Thu, Oct 13, 2016 at 01:47:53PM +0300, Nicolae Rosia wrote: > From: Nicolae Rosia > > Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code > but the register read ended up in the wrong if branch. > Currently, the else branch checks a variable which is always 0. > > Signed-off-

[U-Boot] [PATCH] power: twl6030: fix code refactoring

2016-10-13 Thread Nicolae Rosia
From: Nicolae Rosia Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code but the register read ended up in the wrong if branch. Currently, the else branch checks a variable which is always 0. Signed-off-by: Nicolae Rosia --- drivers/power/twl6030.c | 4 ++-- 1 file changed, 2 in