Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-21 Thread Marek Vasut
On 4/4/19 2:42 PM, Eugeniu Rosca wrote: > Hi Marek, Hi, > On Thu, Apr 04, 2019 at 03:36:45AM +0200, Marek Vasut wrote: > [..] >> I was thinking about this patch further and I think the best way forward >> would be to extend the pinmux/pinctrl API with a callback to set a pin >> as GPIO and then j

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-04 Thread Eugeniu Rosca
Hi Marek, On Thu, Apr 04, 2019 at 03:36:45AM +0200, Marek Vasut wrote: [..] > I was thinking about this patch further and I think the best way forward > would be to extend the pinmux/pinctrl API with a callback to set a pin > as GPIO and then just call that API from the GPIO driver. That would be

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-03 Thread Marek Vasut
On 4/3/19 4:01 PM, Marek Vasut wrote: > On 4/3/19 2:30 PM, Dirk Behme wrote: >> On 03.04.2019 14:11, Marek Vasut wrote: >>> On 4/2/19 7:02 PM, Eugeniu Rosca wrote: On Tue, Apr 02, 2019 at 06:02:46PM +0200, Marek Vasut wrote: > On 4/2/19 5:40 PM, Eugeniu Rosca wrote: >> On Tue, Apr 02,

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-03 Thread Dirk Behme
On 03.04.2019 14:11, Marek Vasut wrote: On 4/2/19 7:02 PM, Eugeniu Rosca wrote: On Tue, Apr 02, 2019 at 06:02:46PM +0200, Marek Vasut wrote: On 4/2/19 5:40 PM, Eugeniu Rosca wrote: On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: On 4/2/19 5:17 PM, Dirk Behme wrote: On 02.04.19 1

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-03 Thread Marek Vasut
On 4/3/19 2:30 PM, Dirk Behme wrote: > On 03.04.2019 14:11, Marek Vasut wrote: >> On 4/2/19 7:02 PM, Eugeniu Rosca wrote: >>> On Tue, Apr 02, 2019 at 06:02:46PM +0200, Marek Vasut wrote: On 4/2/19 5:40 PM, Eugeniu Rosca wrote: > On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-03 Thread Marek Vasut
On 4/2/19 7:02 PM, Eugeniu Rosca wrote: > On Tue, Apr 02, 2019 at 06:02:46PM +0200, Marek Vasut wrote: >> On 4/2/19 5:40 PM, Eugeniu Rosca wrote: >>> On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: On 4/2/19 5:17 PM, Dirk Behme wrote: > On 02.04.19 15:34, Marek Vasut wrote: >>

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-03 Thread Marek Vasut
On 4/2/19 7:58 PM, Dirk Behme wrote: > On 02.04.19 17:40, Eugeniu Rosca wrote: >> On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: >>> On 4/2/19 5:17 PM, Dirk Behme wrote: On 02.04.19 15:34, Marek Vasut wrote: > On 4/2/19 3:18 PM, Eugeniu Rosca wrote: >> With CONFIG_PINCTRL

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Dirk Behme
On 02.04.19 17:40, Eugeniu Rosca wrote: On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: On 4/2/19 5:17 PM, Dirk Behme wrote: On 02.04.19 15:34, Marek Vasut wrote: On 4/2/19 3:18 PM, Eugeniu Rosca wrote: With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: -8<-    LD

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Eugeniu Rosca
On Tue, Apr 02, 2019 at 06:02:46PM +0200, Marek Vasut wrote: > On 4/2/19 5:40 PM, Eugeniu Rosca wrote: > > On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: > >> On 4/2/19 5:17 PM, Dirk Behme wrote: > >>> On 02.04.19 15:34, Marek Vasut wrote: > On 4/2/19 3:18 PM, Eugeniu Rosca wrote

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Marek Vasut
On 4/2/19 5:40 PM, Eugeniu Rosca wrote: > On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: >> On 4/2/19 5:17 PM, Dirk Behme wrote: >>> On 02.04.19 15:34, Marek Vasut wrote: On 4/2/19 3:18 PM, Eugeniu Rosca wrote: > With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: >

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Eugeniu Rosca
On Tue, Apr 02, 2019 at 05:28:43PM +0200, Marek Vasut wrote: > On 4/2/19 5:17 PM, Dirk Behme wrote: > > On 02.04.19 15:34, Marek Vasut wrote: > >> On 4/2/19 3:18 PM, Eugeniu Rosca wrote: > >>> With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: > >>> > >>> -8<- > >>>    LD  u-boot

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Marek Vasut
On 4/2/19 5:17 PM, Dirk Behme wrote: > On 02.04.19 15:34, Marek Vasut wrote: >> On 4/2/19 3:18 PM, Eugeniu Rosca wrote: >>> With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: >>> >>> -8<- >>>    LD  u-boot >>> drivers/gpio/built-in.o: In function `rcar_gpio_request': >>> drivers/g

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Dirk Behme
On 02.04.19 15:34, Marek Vasut wrote: On 4/2/19 3:18 PM, Eugeniu Rosca wrote: With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: -8<- LD u-boot drivers/gpio/built-in.o: In function `rcar_gpio_request': drivers/gpio/gpio-rcar.c:128: undefined reference to `sh_pfc_config_mu

Re: [U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Marek Vasut
On 4/2/19 3:18 PM, Eugeniu Rosca wrote: > With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: > > -8<- > LD u-boot > drivers/gpio/built-in.o: In function `rcar_gpio_request': > drivers/gpio/gpio-rcar.c:128: undefined reference to > `sh_pfc_config_mux_for_gpio' > -8<- >

[U-Boot] [PATCH] pinctrl: renesas: Fix linker error when PINCTRL_PFC=n

2019-04-02 Thread Eugeniu Rosca
With CONFIG_PINCTRL_PFC=n, aarch64-linux-gnu-ld reports: -8<- LD u-boot drivers/gpio/built-in.o: In function `rcar_gpio_request': drivers/gpio/gpio-rcar.c:128: undefined reference to `sh_pfc_config_mux_for_gpio' -8<- Fix it in the least intrusive way and *avoid* ifdefs in