Re: [U-Boot] [PATCH] phylib: Detect link on 10G devices correctly

2011-07-27 Thread Wolfgang Denk
Dear Andy Fleming, In message <1305762259-5639-1-git-send-email-aflem...@freescale.com> you wrote: > gen10g_startup() had 2 bugs: > > 1) It had a boolean logic error in checking the MMD mask, and > always checked all of them. > > 2) It checked devices which don't actually report link state, whic

Re: [U-Boot] [PATCH] phylib: Detect link on 10G devices correctly

2011-05-19 Thread Detlev Zundel
Hi Andy, > gen10g_startup() had 2 bugs: > > 1) It had a boolean logic error in checking the MMD mask, and > always checked all of them. Good catch. > 2) It checked devices which don't actually report link state, which > meant that it would never believe the link was fully up. > > Fix the boolean

[U-Boot] [PATCH] phylib: Detect link on 10G devices correctly

2011-05-18 Thread Andy Fleming
gen10g_startup() had 2 bugs: 1) It had a boolean logic error in checking the MMD mask, and always checked all of them. 2) It checked devices which don't actually report link state, which meant that it would never believe the link was fully up. Fix the boolean logic, and then mask the MMD mask so