Re: [U-Boot] [PATCH] net: phy: vitesse: Fix cis8204 RGMII_ID code

2017-02-02 Thread Joe Hershberger
On Mon, Dec 12, 2016 at 9:27 AM, Phil Edworthy wrote: > Commit 79e86ccb3786c8b20004db3fa10a70049456f580 "vitesse: remove duplicated > argument to ||" correctly removed a redundant check. > > However, I believe that the original code was simply wrong, and should have > been checking against RGMII_I

[U-Boot] [PATCH] net: phy: vitesse: Fix cis8204 RGMII_ID code

2016-12-12 Thread Phil Edworthy
Commit 79e86ccb3786c8b20004db3fa10a70049456f580 "vitesse: remove duplicated argument to ||" correctly removed a redundant check. However, I believe that the original code was simply wrong, and should have been checking against RGMII_ID. To fix this and avoid similar problems in the future, use th