Re: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-16 Thread Mike Frysinger
On Monday 16 January 2012 06:18:26 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > The code which you remove here does NOT depend on CONFIG_CMD_NET; > > > note that this is intentional. > > > > i noticed that, however, i'm not sure it matters. i can't find any place > > in u- boot that actuall

Re: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-16 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201201160505.17834.vap...@gentoo.org> you wrote: > > > The code which you remove here does NOT depend on CONFIG_CMD_NET; > > note that this is intentional. > > i noticed that, however, i'm not sure it matters. i can't find any place in > u- > boot that actually r

Re: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-16 Thread Mike Frysinger
On Monday 16 January 2012 03:03:23 Wolfgang Denk wrote: > Mike Frysinger wrote: > > All arches init these variables the same way, so move the logic > > into the core net code to avoid duplicating it everywhere else. > > This is the wrong approach. > > There are many more ieces of code in arch/*/l

Re: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-16 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1326670329-18644-1-git-send-email-vap...@gentoo.org> you wrote: > All arches init these variables the same way, so move the logic > into the core net code to avoid duplicating it everywhere else. This is the wrong approach. There are many more ieces of code in ar

Re: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-15 Thread Thomas Chou
Hi Mike, On 01/16/2012 07:32 AM, Mike Frysinger wrote: All arches init these variables the same way, so move the logic into the core net code to avoid duplicating it everywhere else. Signed-off-by: Mike Frysinger --- arch/arm/lib/board.c| 11 --- arch/avr32/lib/board.c

[U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize

2012-01-15 Thread Mike Frysinger
All arches init these variables the same way, so move the logic into the core net code to avoid duplicating it everywhere else. Signed-off-by: Mike Frysinger --- arch/arm/lib/board.c| 11 --- arch/avr32/lib/board.c |5 - arch/blackfin/lib/board.c |9 +