Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-22 Thread Jeroen Hofstee
Hello Siarhei, On 07/21/2017 08:46 PM, Siarhei Siamashka wrote: On Wed, 19 Jul 2017 20:26:54 +0200 Jeroen Hofstee wrote: Hi, On 07/18/2017 08:10 PM, Joe Hershberger wrote: Hi Maxime, On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: The -mno-unaligned-access flag used on ARM to pre

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-21 Thread Siarhei Siamashka
On Fri, 21 Jul 2017 22:15:37 +0300 Siarhei Siamashka wrote: > On Wed, 12 Jul 2017 16:34:50 +0200 > Maxime Ripard wrote: > > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > > unaligned accesses (obviously) will only do so on packed structures. > > This statement

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-21 Thread Siarhei Siamashka
On Wed, 12 Jul 2017 16:34:50 +0200 Maxime Ripard wrote: > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > unaligned accesses (obviously) will only do so on packed structures. This statement seems to be poorly worded. > It seems like gcc 7.1 is a bit stricter than pre

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-21 Thread Siarhei Siamashka
On Wed, 19 Jul 2017 20:26:54 +0200 Jeroen Hofstee wrote: > Hi, > > > On 07/18/2017 08:10 PM, Joe Hershberger wrote: > > Hi Maxime, > > > > On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard > > wrote: > >> The -mno-unaligned-access flag used on ARM to prevent GCC from generating > >> unaligned a

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-19 Thread Jeroen Hofstee
Hi, On 07/18/2017 08:10 PM, Joe Hershberger wrote: Hi Maxime, On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: The -mno-unaligned-access flag used on ARM to prevent GCC from generating unaligned accesses (obviously) will only do so on packed structures. It seems like gcc 7.1 is a bit s

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-19 Thread Joe Hershberger
On Wed, Jul 19, 2017 at 2:01 AM, Maxime Ripard wrote: > Hi Joe, > > On Tue, Jul 18, 2017 at 01:10:59PM -0500, Joe Hershberger wrote: >> On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard >> wrote: >> > The -mno-unaligned-access flag used on ARM to prevent GCC from generating >> > unaligned accesses (

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-19 Thread Joe Hershberger
On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > unaligned accesses (obviously) will only do so on packed structures. > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, > and using it le

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-19 Thread Maxime Ripard
Hi Joe, On Tue, Jul 18, 2017 at 01:10:59PM -0500, Joe Hershberger wrote: > On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard > wrote: > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > > unaligned accesses (obviously) will only do so on packed structures. > > > > It seem

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-18 Thread Joe Hershberger
Hi Maxime, On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > unaligned accesses (obviously) will only do so on packed structures. > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, > and

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-17 Thread Tom Rini
On Mon, Jul 17, 2017 at 11:29:39AM +0200, Maxime Ripard wrote: > On Wed, Jul 12, 2017 at 04:37:43PM +0200, Dr. Philipp Tomsich wrote: > > > > > On 12 Jul 2017, at 16:34, Maxime Ripard > > > wrote: > > > > > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > > > unalig

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-17 Thread Maxime Ripard
On Wed, Jul 12, 2017 at 04:37:43PM +0200, Dr. Philipp Tomsich wrote: > > > On 12 Jul 2017, at 16:34, Maxime Ripard > > wrote: > > > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > > unaligned accesses (obviously) will only do so on packed structures. > > > > It se

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-12 Thread Dr. Philipp Tomsich
> On 12 Jul 2017, at 16:34, Maxime Ripard > wrote: > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > unaligned accesses (obviously) will only do so on packed structures. > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, > and using it

[U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-12 Thread Maxime Ripard
The -mno-unaligned-access flag used on ARM to prevent GCC from generating unaligned accesses (obviously) will only do so on packed structures. It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, and using it lead to data abort for unaligned accesses when generating network

[U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-12 Thread Maxime Ripard
The -mno-unaligned-access flag used on ARM to prevent GCC from generating unaligned accesses (obviously) will only do so on packed structures. It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, and using it lead to data abort for unaligned accesses when generating network