Re: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-08 Thread Mike Frysinger
On Wednesday, September 08, 2010 13:11:14 John Rigby wrote: > One more question however, why does eth_initialize call dev->write_hwaddr? as part of the debate "program the MAC without actually using the network" -mike signature.asc Description: This is a digitally signed message part. __

Re: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-08 Thread John Rigby
On Wed, Sep 8, 2010 at 10:07 AM, Mike Frysinger wrote: > > and if you read the doumentation, you'll see that you're mistaken.  whatever > device you're dealing with (today) is missing a call to its own write_hwaaddr > function inside of its own init function. > > if you want to fix your immediate

Re: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-08 Thread Mike Frysinger
On Wednesday, September 08, 2010 11:06:54 John Rigby wrote: please do not top post > The case I am personally dealing with is one where there is no > persistent storage > for ethaddr. Booting from and SD card and a script is run that sets > the ethaddr. > > Currently eth_init updates dev->eneta

Re: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-08 Thread John Rigby
The case I am personally dealing with is one where there is no persistent storage for ethaddr. Booting from and SD card and a script is run that sets the ethaddr. Currently eth_init updates dev->enetaddr for each device but does not call dev-write_hwaddr. This seems like a bug not a policy chang

Re: [U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-07 Thread Mike Frysinger
On Tuesday, September 07, 2010 18:50:26 John Rigby wrote: > When eth_init updates dev->enetaddr it does not > call dev->write_hwaddr. Fix that so when ethaddr > is set after eth_initialize the change will propagate > to the hw. current policy is that the driver init() is supposed to be taking car

[U-Boot] [PATCH] net/eth.c call dev->write_hwaddr in eth_init

2010-09-07 Thread John Rigby
When eth_init updates dev->enetaddr it does not call dev->write_hwaddr. Fix that so when ethaddr is set after eth_initialize the change will propagate to the hw. Signed-off-by: John Rigby --- net/eth.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/n