Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-20 Thread Mike Frysinger
On Friday 20 July 2012 04:24:55 Macpaul Lin wrote: > Since this discussion hasn't been finished, > and we haven't decide the final action about the new policy about cache.h > and common.h. > I'd like to pick this patch v2 for the coming release for fixing build > error for board adp-ag102. > What d

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-20 Thread Macpaul Lin
Hi Marek and Mike, > sounds like we should rip all this cache stuff out of common.h and into > > like cache.h so we can document the API expectations. i think Wolfgang > > was against this before, but maybe that was just creating a header for > one > > specific cache macro and not all cache stuff

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-19 Thread Marek Vasut
Dear Mike Frysinger, > On Thursday 19 July 2012 05:02:21 Marek Vasut wrote: > > Dear Mike Frysinger, > > > > > On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > > > > Dear Macpaul Lin, > > > > > > > > > +void flush_cache(unsigned long addr, unsigned long size) > > > > > +{ > > > > > + flu

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-19 Thread Mike Frysinger
On Thursday 19 July 2012 05:02:21 Marek Vasut wrote: > Dear Mike Frysinger, > > On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > > > Dear Macpaul Lin, > > > > +void flush_cache(unsigned long addr, unsigned long size) > > > > +{ > > > > + flush_dcache_range(addr, addr + size); > > > > +

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-19 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > > Dear Macpaul Lin, > > > > > +void flush_cache(unsigned long addr, unsigned long size) > > > +{ > > > + flush_dcache_range(addr, addr + size); > > > + invalidate_icache_range(addr, addr + size); > > > > You probably wan

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-18 Thread Macpaul Lin
Hi Mike 2012/7/19 Mike Frysinger > On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > > Dear Macpaul Lin, > > > +void flush_cache(unsigned long addr, unsigned long size) > > > +{ > > > + flush_dcache_range(addr, addr + size); > > > + invalidate_icache_range(addr, addr + size); > > > > You

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-18 Thread Mike Frysinger
On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > Dear Macpaul Lin, > > +void flush_cache(unsigned long addr, unsigned long size) > > +{ > > + flush_dcache_range(addr, addr + size); > > + invalidate_icache_range(addr, addr + size); > > You probably want to flush dcache in here and that's it

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-15 Thread Macpaul Lin
Hi Marek, 2012/7/15 Marek Vasut : > Dear Macpaul Lin, > >> This commit does the following updates. >> 1. Split the common cache access from cpu.c into lib folder. >> 2. Rename the following cache api to adapt common.h >> - dcache_flush_rang -> flush_dcache_rang >> - icache_inval_range -> invalid

Re: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-15 Thread Marek Vasut
Dear Macpaul Lin, > This commit does the following updates. > 1. Split the common cache access from cpu.c into lib folder. > 2. Rename the following cache api to adapt common.h > - dcache_flush_rang -> flush_dcache_rang > - icache_inval_range -> invalidate_icache_range > 3. Add invalidate_dcache

[U-Boot] [PATCH] nds32: split common cache access from cpu into lib

2012-07-14 Thread Macpaul Lin
This commit does the following updates. 1. Split the common cache access from cpu.c into lib folder. 2. Rename the following cache api to adapt common.h - dcache_flush_rang -> flush_dcache_rang - icache_inval_range -> invalidate_icache_range 3. Add invalidate_dcache_range Signed-off-by: Macpaul