Re: [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0

2011-05-13 Thread Scott Wood
On Wed, May 04, 2011 at 11:44:44AM +0200, Stefan Roese wrote: > Patch 65a9db7b [nand_spl: Fix large page nand_command()] broke > nand booting on canyonlands. "options" has to be initialized to > 0. If not, boards might have the NAND_BUSWIDTH_16 bit set, > resulting in wrong offset calculation. > >

Re: [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0

2011-05-06 Thread Stefan Roese
On Wednesday 04 May 2011 19:30:29 Scott Wood wrote: > > + nand_chip.options = 0; > > board_nand_init(&nand_chip); > > > > if (nand_chip.select_chip) > > Maybe nand_chip should be made static so it goes in the BSS? This would > avoid any other such problems, without adding any extra

Re: [U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0

2011-05-04 Thread Scott Wood
On Wed, 4 May 2011 11:44:44 +0200 Stefan Roese wrote: > Patch 65a9db7b [nand_spl: Fix large page nand_command()] broke > nand booting on canyonlands. "options" has to be initialized to > 0. If not, boards might have the NAND_BUSWIDTH_16 bit set, > resulting in wrong offset calculation. > > Signe

[U-Boot] [PATCH] nand_spl: nand_boot.c: Init nand_chip.options to 0

2011-05-04 Thread Stefan Roese
Patch 65a9db7b [nand_spl: Fix large page nand_command()] broke nand booting on canyonlands. "options" has to be initialized to 0. If not, boards might have the NAND_BUSWIDTH_16 bit set, resulting in wrong offset calculation. Signed-off-by: Stefan Roese Cc: Scott Wood Cc: Alex Waterman --- nand