Re: [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

--- On Fri, 8/20/10, Stefano Babic wrote: ... > > This is exactly what you want to add, only after setting > the regulators. > Why do we need to set the gpio twice ? You are right. Please disregard my patch. Regards, Fabio Estevam ___ U-Boo

Re: [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

Fabio Estevam wrote: > Hi Stefano, > Hi Fabio, >> udelay(200); >> mxc_gpio_set(46); This must be, >> >> What do you think ? > > Yes, I agree. Do you plan to send a patch for mx51evk using this approach? > > If you do, then I can re-submit my patch after your update. I sent today a pa

Re: [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

Hi Stefano, --- On Fri, 8/20/10, Stefano Babic wrote: ... > > I know I am responsible for this usage, because I forget to > add some > accessors for the gpio pins - as I see your patch, I have > sent a patch > to support it. However, a direct access to registers using > offsets is > not allowed

Re: [U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

Fabio Estevam wrote: > Provide a proper reset for the Ethernet PHY (LAN8700) on the MX51EVK. > Hi Fabio, > Signed-off-by: Fabio Estevam > --- > board/freescale/mx51evk/mx51evk.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/board/freescale/mx51evk/mx51evk.c

[U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

Provide a proper reset for the Ethernet PHY (LAN8700) on the MX51EVK. Signed-off-by: Fabio Estevam --- board/freescale/mx51evk/mx51evk.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c index 75d642