Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-24 Thread Srinivas, Prathap
@lists.denx.de Subject: Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM Remi, I have fixed your comments and updated the patch. Please let me know if there are any further comments on this? Thanks, Prathap. -Original Message- From: l.ping...@gmail.com [mailto:l.ping...@gmail.com] On

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-19 Thread Srinivas, Prathap
Remi, I have fixed your comments and updated the patch. Please let me know if there are any further comments on this? Thanks, Prathap. -Original Message- From: l.ping...@gmail.com [mailto:l.ping...@gmail.com] On Behalf Of Remy Bohmer Sent: Monday, January 11, 2010 2:02 PM To: Srinivas, Pr

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-11 Thread Remy Bohmer
Hi, >> @@ -41,10 +42,24 @@ struct davinci_usb_regs *dregs; >>  static u8 phy_on(void) >>  { >>        u32 timeout; >> +       u32 val; > > This variable is only used when  DAVINCI_DM365EVM is set, so it will > produce a warning if it is not set. > > - We could either initialize the variable or gu

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-10 Thread Srinivas, Prathap
Remy, Thanks a lot for your comments. Please find my response inline. Thanks, Prathap. -Original Message- From: l.ping...@gmail.com [mailto:l.ping...@gmail.com] On Behalf Of Remy Bohmer Sent: Saturday, January 09, 2010 2:50 PM To: Srinivas, Prathap Cc: u-boot@lists.denx.de Subject: Re:

Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-09 Thread Remy Bohmer
Hi, I have put some comments inline: > @@ -41,10 +42,24 @@ struct davinci_usb_regs *dregs; >  static u8 phy_on(void) >  { >        u32 timeout; > +       u32 val; This variable is only used when DAVINCI_DM365EVM is set, so it will produce a warning if it is not set. >        /* Wait until the

[U-Boot] [PATCH] musb: Add host support for DM365 EVM

2010-01-08 Thread Prathap Srinivas
Add support for musb host on DM365 EVM. Signed-off-by: Prathap Srinivas --- drivers/usb/musb/davinci.c | 18 +++- drivers/usb/musb/davinci.h |1 + include/configs/davinci_dm365evm.h | 40 3 files changed, 58 insertions(+),