Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-11 Thread Scott Wood
On 03/09/2013 07:06:54 PM, htbegin wrote: Hi, Scott On Fri, Mar 8, 2013 at 6:27 AM, Scott Wood wrote: >> >> I just use "*length -= left_to_write - written_size" to tell the upper >> >> level that what >> >> had been actually happened. For the current block, "written_size" has >> >> be

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-09 Thread htbegin
Hi, Scott On Fri, Mar 8, 2013 at 6:27 AM, Scott Wood wrote: >> >> I just use "*length -= left_to_write - written_size" to tell the upper >> >> level that what >> >> had been actually happened. For the current block, "written_size" has >> >> been written to the NAND Flash yet, so left_to_write sh

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-07 Thread Scott Wood
On 03/07/2013 09:02:27 AM, htbegin wrote: Hi, Scott On Thu, Mar 7, 2013 at 2:22 AM, Scott Wood wrote: > On 03/06/2013 08:56:56 AM, htbegin wrote: >> > BTW, are you actually using WITH_YAFFS_OOB? I think there are some >> > other >> > things wrong with it at the moment, as mentioned here:

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-07 Thread htbegin
Hi, Scott On Thu, Mar 7, 2013 at 2:22 AM, Scott Wood wrote: > On 03/06/2013 08:56:56 AM, htbegin wrote: >> >> Hi, Scott >> >> Thanks for your review. >> >> On Tue, Mar 5, 2013 at 9:58 AM, Scott Wood >> wrote: >> > On 03/02/2013 03:01:10 AM, Tao Hou wrote: >> >> >> >> When the data has been parti

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-06 Thread Scott Wood
On 03/06/2013 08:56:56 AM, htbegin wrote: Hi, Scott Thanks for your review. On Tue, Mar 5, 2013 at 9:58 AM, Scott Wood wrote: > On 03/02/2013 03:01:10 AM, Tao Hou wrote: >> >> When the data has been partially written into the NAND Flash, >> returning the written length instead of 0. The wri

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-06 Thread htbegin
Hi, Scott Thanks for your review. On Tue, Mar 5, 2013 at 9:58 AM, Scott Wood wrote: > On 03/02/2013 03:01:10 AM, Tao Hou wrote: >> >> When the data has been partially written into the NAND Flash, >> returning the written length instead of 0. The written length >> may be useful when the upper lev

Re: [U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-04 Thread Scott Wood
On 03/02/2013 03:01:10 AM, Tao Hou wrote: When the data has been partially written into the NAND Flash, returning the written length instead of 0. The written length may be useful when the upper level decides to continue the writing after skipping the block causing the write failure. We already

[U-Boot] [PATCH] mtd: nand: fix the written length when nand_write_skip_bad failed

2013-03-02 Thread Tao Hou
When the data has been partially written into the NAND Flash, returning the written length instead of 0. The written length may be useful when the upper level decides to continue the writing after skipping the block causing the write failure. Signed-off-by: Tao Hou Cc: Scott Wood Cc: Ben Gardine