Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-09-01 Thread Haavard Skinnemoen
John Rigby <[EMAIL PROTECTED]> wrote: > Any problem with this going in via the coldfire tree? Or does someone > else want to pick it up? Fine with me. Haavard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Liew Tsi Chung-R5AAHP
y John-R61273; Jason McMullan Subject: Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash On Thu, Aug 28, 2008 at 06:44:56AM -0700, Liew Tsi Chung-R5AAHP wrote: > >> + { > >> + .idcode1 = STM_ID_M25P80, > >> + .page_size = 256, > >> + .pages_per

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread John Rigby
Any problem with this going in via the coldfire tree? Or does someone else want to pick it up? Tsi-Chung Liew wrote: > From: TsiChung Liew <[EMAIL PROTECTED]> > > Add MTD SPI Flash support for M25P16, M25P20, M25P32, > M25P40, M25P64, M25P80, M25P128. > > Signed-off-by: Jason McMullan <[EMAIL PR

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Scott Wood
Liew Tsi Chung-R5AAHP wrote: > Scott, > > I do have -i8 included. So, which one I should edit by hand? The > " }," or " . =". Both. It should look like this: struct foo bar[] = { { .aoeu = AOEU1, .htns = HTNS1, }, {

[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Tsi-Chung Liew
From: TsiChung Liew <[EMAIL PROTECTED]> Add MTD SPI Flash support for M25P16, M25P20, M25P32, M25P40, M25P64, M25P80, M25P128. Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> --- drivers/mtd/spi/Makefile |1 + drivers/mtd/spi/spi

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Scott Wood
On Thu, Aug 28, 2008 at 06:44:56AM -0700, Liew Tsi Chung-R5AAHP wrote: > >> + { > >> + .idcode1 = STM_ID_M25P80, > >> + .page_size = 256, > >> + .pages_per_sector = 256, > >> + .nr_sectors = 16, > >> + .name = "M25P80", > >> + }, > >> + { > >> + .idcode1 = STM_ID_M25P128, > >> + .

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Liew Tsi Chung-R5AAHP
Haavard, > Looks good to me, except... >> +static const struct stmicro_spi_flash_params stmicro_spi_flash_table[] = { >> +{ >> + .idcode1 = STM_ID_M25P16, >> + .page_size = 256, >> + .pages_per_sector = 256, >> + .nr_sectors = 32, >> + .name = "M25P16", >> + }, >> +

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-28 Thread Haavard Skinnemoen
Tsi-Chung Liew <[EMAIL PROTECTED]> wrote: > From: TsiChung Liew <[EMAIL PROTECTED]> > > Add MTD SPI Flash support for M25P16, M25P20, M25P32, > M25P40, M25P64, M25P80, M25P128. > > Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> > Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> Looks good to

[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-22 Thread Tsi-Chung Liew
From: TsiChung Liew <[EMAIL PROTECTED]> Add MTD SPI Flash support for M25P16, M25P20, M25P32, M25P40, M25P64, M25P80, M25P128. Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> --- drivers/mtd/spi/Makefile |1 + drivers/mtd/spi/spi

[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-22 Thread Tsi-Chung Liew
From: TsiChung Liew <[EMAIL PROTECTED]> Add MTD SPI Flash support for M25P16, M25P20, M25P32, M25P40, M25P64, M25P80, M25P128. Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> --- drivers/mtd/spi/Makefile |1 + drivers/mtd/spi/spi

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-22 Thread Liew Tsi Chung-R5AAHP
Haavard, >> - * Copyright 2008, Network Appliance Inc. >> + * Network Appliance Inc. > why do you do this? It must be accidentally deleted which is not intended to, I will resend it again. Mail-archive: > ...which means that you can make these operations cheaper by using > shift and mask instead

Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-22 Thread Haavard Skinnemoen
Tsi-Chung Liew <[EMAIL PROTECTED]> wrote: > From: TsiChung Liew <[EMAIL PROTECTED]> > > Add MTD SPI Flash support for M25P16, M25P40, > M25P64, and M25P80. > > Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> > Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> Ok, good...that should address the

[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

2008-08-21 Thread Tsi-Chung Liew
From: TsiChung Liew <[EMAIL PROTECTED]> Add MTD SPI Flash support for M25P16, M25P40, M25P64, and M25P80. Signed-off-by: Jason McMullan <[EMAIL PROTECTED]> Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]> --- drivers/mtd/spi/stmicro.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)