Re: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-06-04 Thread Stephen Warren
On 05/22/2013 12:48 PM, Stephen Warren wrote: > From: Stephen Warren > > Initialized character arrays on the stack can cause gcc to emit code that > performs unaligned accessess. Make the data static to avoid this. > > Note that the unaligned accesses are made when copying data to prefix[] on >

Re: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-05-27 Thread Stephen Warren
On 05/26/2013 01:28 PM, Simon Glass wrote: > > On Wed, May 22, 2013 at 11:48 AM, Stephen Warren > wrote: > > From: Stephen Warren mailto:swar...@nvidia.com>> > > Initialized character arrays on the stack can cause gcc to emit code > that > performs

Re: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-05-26 Thread Simon Glass
Hi Wolfgang, On Sun, May 26, 2013 at 1:55 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message < > capnjgz1_m-7eggade-p-tlrynpnnxgyh8zh32w8a2+2qgvy...@mail.gmail.com> you > wrote: > > > > Another problem I have is that the 'linux' in 'linux,keymap' in the > device > > compile turns into '

Re: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-05-26 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > Another problem I have is that the 'linux' in 'linux,keymap' in the device > compile turns into '1' since gcc predefines 'linux' to 1: Should this not be considered a GCC bug? After all, "linux" is not a reserved identifier. [Defining __linux, or __l

Re: [U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-05-26 Thread Simon Glass
On Wed, May 22, 2013 at 11:48 AM, Stephen Warren wrote: > From: Stephen Warren > > Initialized character arrays on the stack can cause gcc to emit code that > performs unaligned accessess. Make the data static to avoid this. > > Note that the unaligned accesses are made when copying data to prefi

[U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

2013-05-22 Thread Stephen Warren
From: Stephen Warren Initialized character arrays on the stack can cause gcc to emit code that performs unaligned accessess. Make the data static to avoid this. Note that the unaligned accesses are made when copying data to prefix[] on the stack from .rodata. By making the data static, the copy