Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Wolfgang Denk
Dear Detlev & Kumar, In message you wrote: > ... > >> + /* reset PSC */ > >> + psc->command = PSC_SEL_MODE_REG_1; > > > > Should we not use accessor function to access the device registers > > (here and in the following code) ? > > Indeed we should. But here we go, I can understand, why this

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Detlev Zundel
Hi Wolfgang, > Dear Detlev Zundel, > > In message <1237914158-15693-6-git-send-email-...@denx.de> you wrote: >> This patch adds advanced diagnosis functions for the inka4x0 board. >> >> Signed-off-by: Andreas Pfefferle >> Signed-off-by: Detlev Zundel > ... >> +extern int inkadiag_init_r (vo

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Heiko Schocher
Hello Detlev, Detlev Zundel wrote: > Hi Heiko, > > >>> +#define GPIO_BASE (u_char *)0x3040 >>> >>> >> should be >> >> #define GPIO_BASE (u_char *)CONFIG_SYS_CS3_START >> > > Fixed, thanks. > > >>> +#define SERIAL_PORT_BASE (u_char *)0x8000 >>> >>> >> this

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Detlev Zundel
Hi Wolfgang, > Dear Heiko & Detlev, > > In message <49c91e04.2020...@denx.de> you wrote: > ... >> > +#define GPIO_BASE (u_char *)0x3040 >> > >> >> should be >> >> #define GPIO_BASE (u_char *)CONFIG_SYS_CS3_START > > or > #define GPIO_BASE ((u_char *)CONFIG_SYS_CS3_START) > ? > >>

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Detlev Zundel
Hi Heiko, >> +#define GPIO_BASE (u_char *)0x3040 >> > > should be > > #define GPIO_BASE (u_char *)CONFIG_SYS_CS3_START Fixed, thanks. >> +#define SERIAL_PORT_BASE(u_char *)0x8000 >> > > this should be > > #define SERIAL_PORT_BASE (u_char *)CONFIG_SYS_CS2_START Fixed, th

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-25 Thread Detlev Zundel
Hi Anatolij, > Hi Detlev, > > Detlev Zundel wrote: >> This patch adds advanced diagnosis functions for the inka4x0 board. >> >> Signed-off-by: Andreas Pfefferle >> Signed-off-by: Detlev Zundel > > Something went wrong here, duplicated e-mail address from > Andreas in your SoB. Also please see s

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Anatolij Gustschin
Hi Detlev, Detlev Zundel wrote: > This patch adds advanced diagnosis functions for the inka4x0 board. > > Signed-off-by: Andreas Pfefferle > Signed-off-by: Detlev Zundel Something went wrong here, duplicated e-mail address from Andreas in your SoB. Also please see some style comments below. >

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Scott Wood
Wolfgang Denk wrote: >> +static int do_inkadiag_serial(cmd_tbl_t *cmdtp, int flag, int argc, >> + char *argv[]) { >> +if (argc < 5) { >> +cmd_usage(cmdtp); >> +return 1; >> +} >> + >> +argc--; >> +argv++; >> + >> +unsigned int num

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Wolfgang Denk
Dear Detlev Zundel, In message <1237914158-15693-6-git-send-email-...@denx.de> you wrote: > This patch adds advanced diagnosis functions for the inka4x0 board. > > Signed-off-by: Andreas Pfefferle > Signed-off-by: Detlev Zundel ... > + extern int inkadiag_init_r (void); > + /* > +

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Wolfgang Denk
Dear Heiko & Detlev, In message <49c91e04.2020...@denx.de> you wrote: ... > > +#define GPIO_BASE (u_char *)0x3040 > > > > should be > > #define GPIO_BASE (u_char *)CONFIG_SYS_CS3_START or #define GPIO_BASE ((u_char *)CONFIG_SYS_CS3_START) ? > > +#define SERIAL_PORT_BASE (u_

Re: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Heiko Schocher
Hello Detlev, Detlev Zundel wrote: > This patch adds advanced diagnosis functions for the inka4x0 board. > > Signed-off-by: Andreas Pfefferle > Signed-off-by: Detlev Zundel > --- > board/inka4x0/Makefile|4 +- > board/inka4x0/inka4x0.c | 19 ++- > board/inka4x0/inkadiag.c | 541 >

[U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-24 Thread Detlev Zundel
This patch adds advanced diagnosis functions for the inka4x0 board. Signed-off-by: Andreas Pfefferle Signed-off-by: Detlev Zundel --- board/inka4x0/Makefile|4 +- board/inka4x0/inka4x0.c | 19 ++- board/inka4x0/inkadiag.c | 541 + includ