Re: [U-Boot] [PATCH] gpio: vybrid: Use proper parameter name for gpio offset

2015-06-09 Thread Axel Lin
2015-06-09 22:37 GMT+08:00 Bhuvanchandra DV : > On 06/09/2015 07:54 PM, Axel Lin wrote: >> >> It's confusing to use gpio as gpio offset parameter so rename it to offset >> for better readability. > > Agreed, but IMHO these offsets any way at the end are the gpio numbers of > individual gpio chip in

Re: [U-Boot] [PATCH] gpio: vybrid: Use proper parameter name for gpio offset

2015-06-09 Thread Bhuvanchandra DV
On 06/09/2015 07:54 PM, Axel Lin wrote: It's confusing to use gpio as gpio offset parameter so rename it to offset for better readability. Agreed, but IMHO these offsets any way at the end are the gpio numbers of individual gpio chip instances. e.g: gpio 2 of gpio chip 1 which is gpio 34. S

[U-Boot] [PATCH] gpio: vybrid: Use proper parameter name for gpio offset

2015-06-09 Thread Axel Lin
It's confusing to use gpio as gpio offset parameter so rename it to offset for better readability. Signed-off-by: Axel Lin --- drivers/gpio/vybrid_gpio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/vybrid_gpio.c b/drivers/gpio/vybri