Re: [U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-23 Thread Marek Vasut
On 5/23/19 8:43 PM, Simon Goldschmidt wrote: > commit 1b898ff ("gpio: dwapb_gpio: convert to livetree") introduced > a bug in that dev->node of the gpio chip was accidentally set to the > of_node of its bank subnode. > > What it meant to do was assign subdev->node, not dev->node. > > While this d

[U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-23 Thread Simon Goldschmidt
commit 1b898ff ("gpio: dwapb_gpio: convert to livetree") introduced a bug in that dev->node of the gpio chip was accidentally set to the of_node of its bank subnode. What it meant to do was assign subdev->node, not dev->node. While this doesn't affect too many use cases, iterating over the gpio c

Re: [U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-22 Thread Marek Vasut
On 5/22/19 10:46 AM, Simon Goldschmidt wrote: > On Tue, May 21, 2019 at 10:22 PM Marek Vasut wrote: >> >> On 5/21/19 10:03 PM, Simon Goldschmidt wrote: >>> commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree") introduced >>> a bug in that dev->node of the gpio chip was accidentally set to

Re: [U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-22 Thread Simon Goldschmidt
On Tue, May 21, 2019 at 10:22 PM Marek Vasut wrote: > > On 5/21/19 10:03 PM, Simon Goldschmidt wrote: > > commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree") introduced > > a bug in that dev->node of the gpio chip was accidentally set to the > > of_node of its bank subnode. > > > > What

Re: [U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-21 Thread Marek Vasut
On 5/21/19 10:03 PM, Simon Goldschmidt wrote: > commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree") introduced > a bug in that dev->node of the gpio chip was accidentally set to the > of_node of its bank subnode. > > What it meant to do was assign subdev->node, not dev->node. > > While

[U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node

2019-05-21 Thread Simon Goldschmidt
commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree") introduced a bug in that dev->node of the gpio chip was accidentally set to the of_node of its bank subnode. What it meant to do was assign subdev->node, not dev->node. While this doesn't affect too many use cases, iterating over the g