Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-07-02 Thread Tom Rini
On Sat, Jun 30, 2018 at 12:35:49PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20180629181550.GG18596@bill-the-cat> you wrote: > > > > > This patch can lead to reading incorrect (old, no longer valid) > > > values without any way for the user to see what is happening. > > > > > > Thi

Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-30 Thread Wolfgang Denk
Dear Tom, In message <20180629181550.GG18596@bill-the-cat> you wrote: > > > This patch can lead to reading incorrect (old, no longer valid) > > values without any way for the user to see what is happening. > > > > This must not be done! > > I'm not 100% sure, after reading all of the code, if th

Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-29 Thread Tom Rini
On Fri, Jun 29, 2018 at 12:57:45PM +0200, Wolfgang Denk wrote: > Dear Joe, > > In message > you > wrote: > > > > > When using a redundant environment a read error should simply mean to > > > not use that copy instead of giving up completely. The other copy may > > > be just fine. > > > > > > Si

Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-29 Thread Wolfgang Denk
Dear Joe, In message you wrote: > > > When using a redundant environment a read error should simply mean to > > not use that copy instead of giving up completely. The other copy may > > be just fine. > > > > Signed-off-by: Joe Hershberger > > Signed-off-by: Ioan-Adrian Ratiu > > Hey Tom, can

Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-29 Thread Wolfgang Denk
Dear Adrian, In message <20180626093759.24018-1-adrian.ra...@ni.com> you wrote: > From: Joe Hershberger > > When using a redundant environment a read error should simply mean to > not use that copy instead of giving up completely. The other copy may > be just fine. While the general idea is fin

Re: [U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-26 Thread Joe Hershberger
On Tue, Jun 26, 2018 at 4:37 AM, Ioan-Adrian Ratiu wrote: > From: Joe Hershberger > > When using a redundant environment a read error should simply mean to > not use that copy instead of giving up completely. The other copy may > be just fine. > > Signed-off-by: Joe Hershberger > Signed-off-by:

[U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

2018-06-26 Thread Ioan-Adrian Ratiu
From: Joe Hershberger When using a redundant environment a read error should simply mean to not use that copy instead of giving up completely. The other copy may be just fine. Signed-off-by: Joe Hershberger Signed-off-by: Ioan-Adrian Ratiu --- tools/env/fw_env.c | 24 +++-