Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-23 Thread Bin Meng
Hi Andre, On Sat, Dec 22, 2018 at 7:07 PM Andre Heider wrote: > > Hi Bin, > > this patch reminds me of one I sent some time ago: > http://patchwork.ozlabs.org/patch/873666/ > > I forgot about it, so didn't follow up on the comments, but iirc this > fixed a 'Bad CBFS file' error for me too. Does t

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-22 Thread Andre Heider
Hi Bin, this patch reminds me of one I sent some time ago: http://patchwork.ozlabs.org/patch/873666/ I forgot about it, so didn't follow up on the comments, but iirc this fixed a 'Bad CBFS file' error for me too. Does that work for you? Regards, Andre On 22/12/2018 10:58, Bin Meng wrote: Hi

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-22 Thread Bin Meng
Hi Christian, On Tue, Dec 18, 2018 at 4:57 PM Bin Meng wrote: > > Hi Christian, > > On Tue, Dec 18, 2018 at 4:18 PM Christian Gmeiner > wrote: > > > > Am Mi., 12. Dez. 2018 um 15:27 Uhr schrieb Christian Gmeiner > > : > > > > > > Hi Bin, > > > > > > Finally I have some time to look deeper into t

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-18 Thread Bin Meng
Hi Christian, On Tue, Dec 18, 2018 at 4:18 PM Christian Gmeiner wrote: > > Am Mi., 12. Dez. 2018 um 15:27 Uhr schrieb Christian Gmeiner > : > > > > Hi Bin, > > > > Finally I have some time to look deeper into this issue. > > > > > > > > On Thu, Sep 20, 2018 at 10:47 PM Christian Gmeiner > > > wr

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-18 Thread Christian Gmeiner
Am Mi., 12. Dez. 2018 um 15:27 Uhr schrieb Christian Gmeiner : > > Hi Bin, > > Finally I have some time to look deeper into this issue. > > > > > On Thu, Sep 20, 2018 at 10:47 PM Christian Gmeiner > > wrote: > > > > > > Coreboot does not contain such a check: > > > https://github.com/coreboot/core

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-12-12 Thread Christian Gmeiner
Hi Bin, Finally I have some time to look deeper into this issue. > > On Thu, Sep 20, 2018 at 10:47 PM Christian Gmeiner > wrote: > > > > Coreboot does not contain such a check: > > https://github.com/coreboot/coreboot/blob/eeb4e20b2f6d786c92fe3efb30817e90389a2bfe/src/commonlib/cbfs.c#L64 > > > >

Re: [U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-09-26 Thread Bin Meng
+Simon, Hi Christian, On Thu, Sep 20, 2018 at 10:47 PM Christian Gmeiner wrote: > > Coreboot does not contain such a check: > https://github.com/coreboot/coreboot/blob/eeb4e20b2f6d786c92fe3efb30817e90389a2bfe/src/commonlib/cbfs.c#L64 > > Before this change cbfsinit failed with 'Bad CBFS file'. A

[U-Boot] [PATCH] fs: cbfs: remove wrong header validation

2018-09-20 Thread Christian Gmeiner
Coreboot does not contain such a check: https://github.com/coreboot/coreboot/blob/eeb4e20b2f6d786c92fe3efb30817e90389a2bfe/src/commonlib/cbfs.c#L64 Before this change cbfsinit failed with 'Bad CBFS file'. After this change all cbfs commands are working as expected. Signed-off-by: Christian Gmein