Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-08-02 Thread Simon Glass
Hi Tim, On 14 May 2015 at 07:11, Tim Harvey wrote: > On Wed, May 13, 2015 at 8:22 PM, Simon Glass wrote: >> Hi, >> >> On 13 May 2015 at 20:02, Simon Glass wrote: >>> Hi, >>> >>> On 13 May 2015 at 16:40, Tim Harvey wrote: On Wed, May 13, 2015 at 12:58 PM, Tim Harvey wrote: > >>> Tom,

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-14 Thread Tim Harvey
On Wed, May 13, 2015 at 8:22 PM, Simon Glass wrote: > Hi, > > On 13 May 2015 at 20:02, Simon Glass wrote: >> Hi, >> >> On 13 May 2015 at 16:40, Tim Harvey wrote: >>> On Wed, May 13, 2015 at 12:58 PM, Tim Harvey wrote: >> >>> Tom, >>> >>> I don't really understand the CONFIG_SPL_STACK_R usage at

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-13 Thread Simon Glass
Hi, On 13 May 2015 at 20:02, Simon Glass wrote: > Hi, > > On 13 May 2015 at 16:40, Tim Harvey wrote: >> On Wed, May 13, 2015 at 12:58 PM, Tim Harvey wrote: >>> On Tue, May 12, 2015 at 8:14 AM, Tom Rini wrote: On Mon, May 11, 2015 at 12:08:25PM -0700, Tim Harvey wrote: > On Fri, May 8,

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-13 Thread Simon Glass
Hi, On 13 May 2015 at 16:40, Tim Harvey wrote: > On Wed, May 13, 2015 at 12:58 PM, Tim Harvey wrote: >> On Tue, May 12, 2015 at 8:14 AM, Tom Rini wrote: >>> On Mon, May 11, 2015 at 12:08:25PM -0700, Tim Harvey wrote: On Fri, May 8, 2015 at 4:14 PM, Tom Rini wrote: > On Sat, May 09, 2

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-13 Thread Tim Harvey
On Wed, May 13, 2015 at 12:58 PM, Tim Harvey wrote: > On Tue, May 12, 2015 at 8:14 AM, Tom Rini wrote: >> On Mon, May 11, 2015 at 12:08:25PM -0700, Tim Harvey wrote: >>> On Fri, May 8, 2015 at 4:14 PM, Tom Rini wrote: >>> > On Sat, May 09, 2015 at 12:15:37AM +0200, Marek Vasut wrote: >>> >> On F

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-13 Thread Tim Harvey
On Tue, May 12, 2015 at 8:14 AM, Tom Rini wrote: > On Mon, May 11, 2015 at 12:08:25PM -0700, Tim Harvey wrote: >> On Fri, May 8, 2015 at 4:14 PM, Tom Rini wrote: >> > On Sat, May 09, 2015 at 12:15:37AM +0200, Marek Vasut wrote: >> >> On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: >> >>

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-12 Thread Tom Rini
On Mon, May 11, 2015 at 12:08:25PM -0700, Tim Harvey wrote: > On Fri, May 8, 2015 at 4:14 PM, Tom Rini wrote: > > On Sat, May 09, 2015 at 12:15:37AM +0200, Marek Vasut wrote: > >> On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: > >> > Allocating space for temporary env on the stack makes

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-11 Thread Tim Harvey
On Fri, May 8, 2015 at 4:14 PM, Tom Rini wrote: > On Sat, May 09, 2015 at 12:15:37AM +0200, Marek Vasut wrote: >> On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: >> > Allocating space for temporary env on the stack makes env_relocate_spec() >> > unsuitable for SPL environments which have

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-11 Thread Tim Harvey
On Fri, May 8, 2015 at 3:15 PM, Marek Vasut wrote: > On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: >> Allocating space for temporary env on the stack makes env_relocate_spec() >> unsuitable for SPL environments which have very little stack. > > Well yeah, but what if you don't have mal

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-08 Thread Tom Rini
On Sat, May 09, 2015 at 12:15:37AM +0200, Marek Vasut wrote: > On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: > > Allocating space for temporary env on the stack makes env_relocate_spec() > > unsuitable for SPL environments which have very little stack. > > Well yeah, but what if you do

Re: [U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-08 Thread Marek Vasut
On Friday, May 08, 2015 at 11:51:36 PM, Tim Harvey wrote: > Allocating space for temporary env on the stack makes env_relocate_spec() > unsuitable for SPL environments which have very little stack. Well yeah, but what if you don't have malloc area ? I'd expect that the be the case in SPL quite oft

[U-Boot] [PATCH] env_mmc: avoid stack allocation for env

2015-05-08 Thread Tim Harvey
Allocating space for temporary env on the stack makes env_relocate_spec() unsuitable for SPL environments which have very little stack. Signed-off-by: Tim Harvey --- common/env_mmc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/common/env_mmc.c b/common/env