Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Jaehoon Chung
On 11/29/2013 07:02 PM, Alexey Brodkin wrote: > On Fri, 2013-11-29 at 18:57 +0900, Jaehoon Chung wrote: >> I think good that just removed the "#include ". >> Instead, Exnyos specific code can move into dw-mmc-exynos.c with callback >> function. >> (I didn't know whcih Soc is used with MPSCTRL regi

Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
On Fri, 2013-11-29 at 18:57 +0900, Jaehoon Chung wrote: > I think good that just removed the "#include ". > Instead, Exnyos specific code can move into dw-mmc-exynos.c with callback > function. > (I didn't know whcih Soc is used with MPSCTRL register.) > > > Because of this you selected this offs

Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Jaehoon Chung
Hi Alexey, On 11/29/2013 04:41 PM, Alexey Brodkin wrote: > Hi Jaehoon, > > On Fri, 2013-11-29 at 12:46 +0900, Jaehoon Chung wrote: >> Hi, Alexey, >> >> I didn't know exactly which version is used this register. >> I known this register is used only the exynos series. >> I have checked the IP vers

Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-28 Thread Alexey Brodkin
Hi Jaehoon, On Fri, 2013-11-29 at 12:46 +0900, Jaehoon Chung wrote: > Hi, Alexey, > > I didn't know exactly which version is used this register. > I known this register is used only the exynos series. > I have checked the IP version 2.70a, but CLKSEL(0x9c) wasn't used at general > register map.

Re: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-28 Thread Jaehoon Chung
Hi, Alexey, I didn't know exactly which version is used this register. I known this register is used only the exynos series. I have checked the IP version 2.70a, but CLKSEL(0x9c) wasn't used at general register map. If I missed the something, let me know.(It's published the upper IP version tha

[U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms

2013-11-28 Thread Alexey Brodkin
There's no point in having of "dwmmc.h" per architecure - we're talking about device driver (DesignWare MMC controller) which is expected to work with any CPU it is attached to. So defines used for DW MMC configuration should be in its own header which is avaialble for everybody. Signed-off-by: A