Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-10-09 Thread Anatolij Gustschin
Hi Rob, Simon, On Fri, 6 Oct 2017 11:04:24 -0600 Simon Glass s...@chromium.org wrote: ... > > So I think you should drop/revert this patch > > Seems reasonable to me. OK, I dropped it. Thanks, -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.d

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-10-06 Thread Simon Glass
Hi Rob, On 6 October 2017 at 10:56, Rob Clark wrote: > > On Fri, Oct 6, 2017 at 12:15 PM, Anatolij Gustschin wrote: > > On Sat, 30 Sep 2017 10:19:17 +0200 > > Anatolij Gustschin ag...@denx.de wrote: > > > >> As mentioned in review comments for ANSI escape sequence > >> support patches, this shou

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-10-06 Thread Rob Clark
On Fri, Oct 6, 2017 at 12:15 PM, Anatolij Gustschin wrote: > On Sat, 30 Sep 2017 10:19:17 +0200 > Anatolij Gustschin ag...@denx.de wrote: > >> As mentioned in review comments for ANSI escape sequence >> support patches, this should be optional to reduce code >> size. Disable escape sequence suppor

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-10-06 Thread Anatolij Gustschin
On Sat, 30 Sep 2017 10:19:17 +0200 Anatolij Gustschin ag...@denx.de wrote: > As mentioned in review comments for ANSI escape sequence > support patches, this should be optional to reduce code > size. Disable escape sequence support when CONFIG_VIDEO_ANSI > is not enabled. > > Signed-off-by: Anato

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-09-30 Thread Rob Clark
On Sat, Sep 30, 2017 at 4:19 AM, Anatolij Gustschin wrote: > As mentioned in review comments for ANSI escape sequence > support patches, this should be optional to reduce code > size. Disable escape sequence support when CONFIG_VIDEO_ANSI > is not enabled. Assuming the later version of the patch

[U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

2017-09-30 Thread Anatolij Gustschin
As mentioned in review comments for ANSI escape sequence support patches, this should be optional to reduce code size. Disable escape sequence support when CONFIG_VIDEO_ANSI is not enabled. Signed-off-by: Anatolij Gustschin --- This patch is based on basic ANSI escape seq. support series: https:/