Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-03 Thread Marek Vasut
On 1/3/19 10:47 PM, Lukasz Majewski wrote: > On Fri, 4 Jan 2019 01:23:17 +0530 > Jagan Teki wrote: > >> On Thu, Jan 3, 2019 at 12:29 PM Lukasz Majewski wrote: >>> >>> Hi Jagan, >>> On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot wrote: > > > On 29/12/2018 19:49, Jag

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-03 Thread Lukasz Majewski
On Fri, 4 Jan 2019 01:23:17 +0530 Jagan Teki wrote: > On Thu, Jan 3, 2019 at 12:29 PM Lukasz Majewski wrote: > > > > Hi Jagan, > > > > > On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot > > > wrote: > > > > > > > > > > > > On 29/12/2018 19:49, Jagan Teki wrote: > > > > > On Mon, Dec 24,

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-03 Thread Marek Vasut
On 1/3/19 7:59 AM, Lukasz Majewski wrote: > Hi Jagan, > >> On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot >> wrote: >>> >>> >>> On 29/12/2018 19:49, Jagan Teki wrote: On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki wrote: > On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot >>>

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-03 Thread Marek Vasut
On 1/3/19 8:53 PM, Jagan Teki wrote: > On Thu, Jan 3, 2019 at 12:29 PM Lukasz Majewski wrote: >> >> Hi Jagan, >> >>> On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot >>> wrote: On 29/12/2018 19:49, Jagan Teki wrote: > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > wrote: >

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-03 Thread Jagan Teki
On Thu, Jan 3, 2019 at 12:29 PM Lukasz Majewski wrote: > > Hi Jagan, > > > On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot > > wrote: > > > > > > > > > On 29/12/2018 19:49, Jagan Teki wrote: > > > > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > > > > wrote: > > > >> On Fri, Dec 21, 2018 at 2:2

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-02 Thread Lukasz Majewski
Hi Jagan, > On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot > wrote: > > > > > > On 29/12/2018 19:49, Jagan Teki wrote: > > > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > > > wrote: > > >> On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot > > >> wrote: Better to have proper commit head

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-02 Thread Jagan Teki
On Wed, Jan 2, 2019 at 4:08 PM Jean-Jacques Hiblot wrote: > > > On 29/12/2018 19:49, Jagan Teki wrote: > > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > > wrote: > >> On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot > >> wrote: > >> Better to have proper commit head that tells the real issue

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-02 Thread Jean-Jacques Hiblot
On 02/01/2019 13:15, Lukasz Majewski wrote: On Wed, 2 Jan 2019 11:38:47 +0100 Jean-Jacques Hiblot wrote: On 29/12/2018 19:49, Jagan Teki wrote: On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki wrote: On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot wrote: Better to have proper commit head th

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-02 Thread Lukasz Majewski
On Wed, 2 Jan 2019 11:38:47 +0100 Jean-Jacques Hiblot wrote: > On 29/12/2018 19:49, Jagan Teki wrote: > > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > > wrote: > >> On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot > >> wrote: Better to have proper commit head that > >> tells the real issue

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2019-01-02 Thread Jean-Jacques Hiblot
On 29/12/2018 19:49, Jagan Teki wrote: On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki wrote: On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot wrote: Better to have proper commit head that tells the real issue. I found it hard to come up with a short description of the real issue. At least t

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2018-12-30 Thread Marek Vasut
On 12/29/18 7:49 PM, Jagan Teki wrote: > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki wrote: >> >> On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot wrote: >>> >> >> Better to have proper commit head that tells the real issue. >> >>> Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2018-12-29 Thread Jagan Teki
On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki wrote: > > On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot wrote: > > > > Better to have proper commit head that tells the real issue. > > > Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget > > devices") > > > > The UCLASS_D

Re: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2018-12-23 Thread Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot wrote: > Better to have proper commit head that tells the real issue. > Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget > devices") > > The UCLASS_DRIVER for id UCLASS_USB_GADGET_GENERIC needs to be declared > even fo

[U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms

2018-12-21 Thread Jean-Jacques Hiblot
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices") The UCLASS_DRIVER for id UCLASS_USB_GADGET_GENERIC needs to be declared even for platforms that do not enable DM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind. Reported-by: Pr