Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-20 Thread Eric Nelson
Hi Simon, On 04/20/2016 07:40 AM, Simon Glass wrote: > Hi Eric, > > On 11 April 2016 at 11:17, Eric Nelson wrote: >> On 04/11/2016 09:53 AM, Simon Glass wrote: >>> On 11 April 2016 at 10:10, Stephen Warren wrote: On 04/11/2016 09:12 AM, Simon Glass wrote: > On 11 April 2016 at 09:10, E

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-20 Thread Simon Glass
Hi Eric, On 11 April 2016 at 11:17, Eric Nelson wrote: > On 04/11/2016 09:53 AM, Simon Glass wrote: >> Hi, >> >> On 11 April 2016 at 10:10, Stephen Warren wrote: >>> On 04/11/2016 09:12 AM, Simon Glass wrote: Hi Eric, On 11 April 2016 at 09:10, Eric Nelson wrote: > > >

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Eric Nelson
On 04/11/2016 09:53 AM, Simon Glass wrote: > Hi, > > On 11 April 2016 at 10:10, Stephen Warren wrote: >> On 04/11/2016 09:12 AM, Simon Glass wrote: >>> >>> Hi Eric, >>> >>> On 11 April 2016 at 09:10, Eric Nelson wrote: > I don't think you need __maybe_unused > > static int gp

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Simon Glass
Hi, On 11 April 2016 at 10:10, Stephen Warren wrote: > On 04/11/2016 09:12 AM, Simon Glass wrote: >> >> Hi Eric, >> >> On 11 April 2016 at 09:10, Eric Nelson wrote: >>> >>> Hi Simon, >>> >>> On 04/11/2016 07:59 AM, Simon Glass wrote: On 11 April 2016 at 08:55, Eric Nelson wrote: >

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Stephen Warren
On 04/11/2016 09:12 AM, Simon Glass wrote: Hi Eric, On 11 April 2016 at 09:10, Eric Nelson wrote: Hi Simon, On 04/11/2016 07:59 AM, Simon Glass wrote: On 11 April 2016 at 08:55, Eric Nelson wrote: On 04/11/2016 07:47 AM, Simon Glass wrote: On 10 April 2016 at 08:48, Eric Nelson wrote: O

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Simon Glass
Hi Eric, On 11 April 2016 at 09:10, Eric Nelson wrote: > Hi Simon, > > On 04/11/2016 07:59 AM, Simon Glass wrote: >> On 11 April 2016 at 08:55, Eric Nelson wrote: >>> On 04/11/2016 07:47 AM, Simon Glass wrote: On 10 April 2016 at 08:48, Eric Nelson wrote: > On 04/09/2016 11:33 AM, Simo

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Eric Nelson
Hi Simon, On 04/11/2016 07:59 AM, Simon Glass wrote: > On 11 April 2016 at 08:55, Eric Nelson wrote: >> On 04/11/2016 07:47 AM, Simon Glass wrote: >>> On 10 April 2016 at 08:48, Eric Nelson wrote: On 04/09/2016 11:33 AM, Simon Glass wrote: > On 4 April 2016 at 11:50, Stephen Warren wro

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Simon Glass
Hi Eric, On 11 April 2016 at 08:55, Eric Nelson wrote: > Hi Simon, > > On 04/11/2016 07:47 AM, Simon Glass wrote: >> Hi Eric, >> >> On 10 April 2016 at 08:48, Eric Nelson wrote: >>> Hi Simon, >>> >>> On 04/09/2016 11:33 AM, Simon Glass wrote: On 4 April 2016 at 11:50, Stephen Warren wrote:

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Eric Nelson
Hi Simon, On 04/11/2016 07:47 AM, Simon Glass wrote: > Hi Eric, > > On 10 April 2016 at 08:48, Eric Nelson wrote: >> Hi Simon, >> >> On 04/09/2016 11:33 AM, Simon Glass wrote: >>> On 4 April 2016 at 11:50, Stephen Warren wrote: On 04/03/2016 08:07 AM, Eric Nelson wrote: > On 04/02/2016

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-11 Thread Simon Glass
Hi Eric, On 10 April 2016 at 08:48, Eric Nelson wrote: > Hi Simon, > > On 04/09/2016 11:33 AM, Simon Glass wrote: >> On 4 April 2016 at 11:50, Stephen Warren wrote: >>> On 04/03/2016 08:07 AM, Eric Nelson wrote: On 04/02/2016 08:37 PM, Stephen Warren wrote: > On 04/02/2016 09:13 AM, Eri

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-10 Thread Eric Nelson
Hi Simon, On 04/09/2016 11:33 AM, Simon Glass wrote: > On 4 April 2016 at 11:50, Stephen Warren wrote: >> On 04/03/2016 08:07 AM, Eric Nelson wrote: >>> On 04/02/2016 08:37 PM, Stephen Warren wrote: On 04/02/2016 09:13 AM, Eric Nelson wrote: > On 04/01/2016 10:46 PM, Peng Fan wrote:

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-09 Thread Simon Glass
Hi, On 4 April 2016 at 11:50, Stephen Warren wrote: > On 04/03/2016 08:07 AM, Eric Nelson wrote: >> >> Hi Stephen and Peng, >> >> On 04/02/2016 08:37 PM, Stephen Warren wrote: >>> >>> On 04/02/2016 09:13 AM, Eric Nelson wrote: On 04/01/2016 10:46 PM, Peng Fan wrote: > > On Thu,

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-04 Thread Stephen Warren
On 04/03/2016 08:07 AM, Eric Nelson wrote: Hi Stephen and Peng, On 04/02/2016 08:37 PM, Stephen Warren wrote: On 04/02/2016 09:13 AM, Eric Nelson wrote: On 04/01/2016 10:46 PM, Peng Fan wrote: On Thu, Mar 31, 2016 at 01:41:04PM -0700, Eric Nelson wrote: On 03/28/2016 09:57 PM, Peng Fan wrote

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-03 Thread Eric Nelson
Hi Stephen and Peng, On 04/02/2016 08:37 PM, Stephen Warren wrote: > On 04/02/2016 09:13 AM, Eric Nelson wrote: >> On 04/01/2016 10:46 PM, Peng Fan wrote: >>> On Thu, Mar 31, 2016 at 01:41:04PM -0700, Eric Nelson wrote: On 03/28/2016 09:57 PM, Peng Fan wrote: > On Fri, Mar 25, 2016 at 01:

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-02 Thread Stephen Warren
On 04/02/2016 09:13 AM, Eric Nelson wrote: Hi Peng, On 04/01/2016 10:46 PM, Peng Fan wrote: On Thu, Mar 31, 2016 at 01:41:04PM -0700, Eric Nelson wrote: On 03/28/2016 09:57 PM, Peng Fan wrote: On Fri, Mar 25, 2016 at 01:12:11PM -0700, Eric Nelson wrote: Device tree parsing of GPIO nodes is c

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-02 Thread Eric Nelson
Hi Peng, On 04/01/2016 10:46 PM, Peng Fan wrote: > On Thu, Mar 31, 2016 at 01:41:04PM -0700, Eric Nelson wrote: >> On 03/28/2016 09:57 PM, Peng Fan wrote: >>> On Fri, Mar 25, 2016 at 01:12:11PM -0700, Eric Nelson wrote: Device tree parsing of GPIO nodes is currently ignoring flags.

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-04-01 Thread Peng Fan
Hi Eric, On Thu, Mar 31, 2016 at 01:41:04PM -0700, Eric Nelson wrote: >Hi Peng, > >On 03/28/2016 09:57 PM, Peng Fan wrote: >> Hi Eric, >> >> On Fri, Mar 25, 2016 at 01:12:11PM -0700, Eric Nelson wrote: >>> Device tree parsing of GPIO nodes is currently ignoring flags. >>> >>> Add support for GPIO

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-03-31 Thread Eric Nelson
Hi Peng, On 03/28/2016 09:57 PM, Peng Fan wrote: > Hi Eric, > > On Fri, Mar 25, 2016 at 01:12:11PM -0700, Eric Nelson wrote: >> Device tree parsing of GPIO nodes is currently ignoring flags. >> >> Add support for GPIO_ACTIVE_LOW by checking for the presence >> of the flag and setting the desc->fl

Re: [U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-03-28 Thread Peng Fan
Hi Eric, On Fri, Mar 25, 2016 at 01:12:11PM -0700, Eric Nelson wrote: >Device tree parsing of GPIO nodes is currently ignoring flags. > >Add support for GPIO_ACTIVE_LOW by checking for the presence >of the flag and setting the desc->flags field to the driver >model constant GPIOD_ACTIVE_LOW. You

[U-Boot] [PATCH] dm: gpio: handle GPIO_ACTIVE_LOW flag in DT

2016-03-25 Thread Eric Nelson
Device tree parsing of GPIO nodes is currently ignoring flags. Add support for GPIO_ACTIVE_LOW by checking for the presence of the flag and setting the desc->flags field to the driver model constant GPIOD_ACTIVE_LOW. Signed-off-by: Eric Nelson --- drivers/gpio/gpio-uclass.c | 9 +++-- 1 fil