Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-15 Thread Albert ARIBAUD
Hi Måns, On Tue, 15 Oct 2013 17:29:24 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > > Hi Måns, > > > > On Tue, 15 Oct 2013 16:23:44 +0100, Måns Rullgård > > wrote: > > > >> On the compiler side, gcc traditionally did not issue unaligned > >> load/store instructions on ARM. > > > >

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-15 Thread Måns Rullgård
Albert ARIBAUD writes: > Hi Måns, > > On Tue, 15 Oct 2013 16:23:44 +0100, Måns Rullgård > wrote: > >> On the compiler side, gcc traditionally did not issue unaligned >> load/store instructions on ARM. > > Please be specific: gcc did not emit *native* unaligned accesses. Please explain what you

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-15 Thread Albert ARIBAUD
Hi Måns, On Tue, 15 Oct 2013 16:23:44 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > >> > I sense that you have not understood the reason why I want alignment > >> > checking enabled in ARM yet also want ARMv6+ builds to emit native > >> > unaligned accesses if they consider it neede

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-15 Thread Måns Rullgård
Albert ARIBAUD writes: >> > I sense that you have not understood the reason why I want alignment >> > checking enabled in ARM yet also want ARMv6+ builds to emit native >> > unaligned accesses if they consider it needed. >> >> Your wishes are mutually exclusive. You cannot both allow hardware >

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
Hi Måns, On Mon, 14 Oct 2013 16:59:56 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > > Hi Måns, > > > > On Mon, 14 Oct 2013 15:09:39 +0100, Måns Rullgård > > wrote: > > > >> Albert ARIBAUD writes: > >> > >> > Hi Måns, > >> > > >> > On Mon, 14 Oct 2013 14:05:13 +0100, Måns Rullgård

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Måns Rullgård
Albert ARIBAUD writes: > Hi Måns, > > On Mon, 14 Oct 2013 15:09:39 +0100, Måns Rullgård > wrote: > >> Albert ARIBAUD writes: >> >> > Hi Måns, >> > >> > On Mon, 14 Oct 2013 14:05:13 +0100, Måns Rullgård >> > wrote: >> > >> >> Albert ARIBAUD writes: >> >> >> >> >> > Please do not advise using

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
Hi Måns, On Mon, 14 Oct 2013 15:09:39 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > > Hi Måns, > > > > On Mon, 14 Oct 2013 14:05:13 +0100, Måns Rullgård > > wrote: > > > >> Albert ARIBAUD writes: > >> > >> >> > Please do not advise using native unaligned accesses on code that is

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
ek; 'Tom Rini'; u-boot@lists.denx.de; 'Kyungmin Park' > > Subject: Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi > > partition > > > > Albert ARIBAUD writes: > > > > >> > Please do not advise using native unaligned a

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Måns Rullgård
Albert ARIBAUD writes: > Hi Måns, > > On Mon, 14 Oct 2013 14:05:13 +0100, Måns Rullgård > wrote: > >> Albert ARIBAUD writes: >> >> >> > Please do not advise using native unaligned accesses on code that is >> >> > not strictly used by ARMv6+ architectures: the present code, for >> >> > instance

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Piotr Wilczek
Dear Albert and Måns, > -Original Message- > From: Måns Rullgård [mailto:m...@mansr.com] > Sent: Monday, October 14, 2013 3:05 PM > To: Albert ARIBAUD > Cc: Piotr Wilczek; 'Tom Rini'; u-boot@lists.denx.de; 'Kyungmin Park' > Subject: Re: [U-Boot] [PATC

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
Hi Måns, On Mon, 14 Oct 2013 14:05:13 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > >> > Please do not advise using native unaligned accesses on code that is > >> > not strictly used by ARMv6+ architectures: the present code, for > >> > instance, might be run on pre-ARMv6 or non-ARM

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Måns Rullgård
Albert ARIBAUD writes: >> > Please do not advise using native unaligned accesses on code that is >> > not strictly used by ARMv6+ architectures: the present code, for >> > instance, might be run on pre-ARMv6 or non-ARM platforms, and thus, >> > should never assume ability to perform unaligned acc

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
Hi Måns, On Mon, 14 Oct 2013 13:19:27 +0100, Måns Rullgård wrote: > Albert ARIBAUD writes: > > > Hi Måns, > > > > On Mon, 14 Oct 2013 11:50:42 +0100, Måns Rullgård > > wrote: > > > >> Piotr Wilczek writes: > >> > >> >> -Original Message- > >> >> From: Måns Rullgård [mailto:m...@mans

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Måns Rullgård
Albert ARIBAUD writes: > Hi Måns, > > On Mon, 14 Oct 2013 11:50:42 +0100, Måns Rullgård > wrote: > >> Piotr Wilczek writes: >> >> >> -Original Message- >> >> From: Måns Rullgård [mailto:m...@mansr.com] >> >> Sent: Saturday, October 12, 2013 1:29 AM >> >> To: Piotr Wilczek >> >> Cc: u-b

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Albert ARIBAUD
Hi Måns, On Mon, 14 Oct 2013 11:50:42 +0100, Måns Rullgård wrote: > Piotr Wilczek writes: > > >> -Original Message- > >> From: Måns Rullgård [mailto:m...@mansr.com] > >> Sent: Saturday, October 12, 2013 1:29 AM > >> To: Piotr Wilczek > >> Cc: u-boot@lists.denx.de; Tom Rini; Kyungmin Pa

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Måns Rullgård
Piotr Wilczek writes: >> -Original Message- >> From: Måns Rullgård [mailto:m...@mansr.com] >> Sent: Saturday, October 12, 2013 1:29 AM >> To: Piotr Wilczek >> Cc: u-boot@lists.denx.de; Tom Rini; Kyungmin Park >> Subject: Re: [PATCH] disk:efi: avoid unaligned access on efi partition >> >>

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-14 Thread Piotr Wilczek
> -Original Message- > From: Måns Rullgård [mailto:m...@mansr.com] > Sent: Saturday, October 12, 2013 1:29 AM > To: Piotr Wilczek > Cc: u-boot@lists.denx.de; Tom Rini; Kyungmin Park > Subject: Re: [PATCH] disk:efi: avoid unaligned access on efi partition > > Piotr Wilczek writes: > > >

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-11 Thread Måns Rullgård
Piotr Wilczek writes: > In this patch static variable and memcpy instead of an assignment > are used to avoid unaligned access exception on some ARM platforms. > > Signed-off-by: Piotr Wilczek > Signed-off-by: Kyungmin Park > CC: Tom Rini > --- > disk/part_efi.c |6 -- > 1 file change

Re: [U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-11 Thread Albert ARIBAUD
Hi Piotr, On Fri, 11 Oct 2013 15:31:10 +0200, Piotr Wilczek wrote: > In this patch static variable and memcpy instead of an assignment > are used to avoid unaligned access exception on some ARM platforms. > > Signed-off-by: Piotr Wilczek > Signed-off-by: Kyungmin Park > CC: Tom Rini > --- >

[U-Boot] [PATCH] disk:efi: avoid unaligned access on efi partition

2013-10-11 Thread Piotr Wilczek
In this patch static variable and memcpy instead of an assignment are used to avoid unaligned access exception on some ARM platforms. Signed-off-by: Piotr Wilczek Signed-off-by: Kyungmin Park CC: Tom Rini --- disk/part_efi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff