Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-18 Thread Simon Glass
Hi Simon, On 17 October 2018 at 14:02, Simon Goldschmidt wrote: > > > Simon Goldschmidt schrieb am Mi., 10. Okt. > 2018, 22:16: >> >> On Wed, Oct 10, 2018 at 10:03 PM Simon Glass wrote: >> > >> > Hi Simon, >> > >> > On 10 October 2018 at 07:28, Simon Goldschmidt >> > wrote: >> > > >> > > + Mar

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-17 Thread Simon Goldschmidt
Simon Goldschmidt schrieb am Mi., 10. Okt. 2018, 22:16: > On Wed, Oct 10, 2018 at 10:03 PM Simon Glass wrote: > > > > Hi Simon, > > > > On 10 October 2018 at 07:28, Simon Goldschmidt > > wrote: > > > > > > + Marek (as he commented on the original patch > http://patchwork.ozlabs.org/patch/955765

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-10 Thread Simon Goldschmidt
On Wed, Oct 10, 2018 at 10:03 PM Simon Glass wrote: > > Hi Simon, > > On 10 October 2018 at 07:28, Simon Goldschmidt > wrote: > > > > + Marek (as he commented on the original patch > > http://patchwork.ozlabs.org/patch/955765/) > > > > On 09.10.2018 07:06, Simon Goldschmidt wrote: > >> > >> On T

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-10 Thread Simon Glass
Hi Simon, On 10 October 2018 at 07:28, Simon Goldschmidt wrote: > > + Marek (as he commented on the original patch > http://patchwork.ozlabs.org/patch/955765/) > > On 09.10.2018 07:06, Simon Goldschmidt wrote: >> >> On Tue, Oct 9, 2018 at 5:41 AM Simon Glass wrote: >>> >>> Hi, >>> >>> On 7 Octo

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-10 Thread Simon Goldschmidt
+ Marek (as he commented on the original patch http://patchwork.ozlabs.org/patch/955765/) On 09.10.2018 07:06, Simon Goldschmidt wrote: On Tue, Oct 9, 2018 at 5:41 AM Simon Glass wrote: Hi, On 7 October 2018 at 11:52, Simon Goldschmidt wrote: At least on socfpga gen5, _debug_uart_putc() ca

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-08 Thread Simon Goldschmidt
On Tue, Oct 9, 2018 at 5:41 AM Simon Glass wrote: > > Hi, > > On 7 October 2018 at 11:52, Simon Goldschmidt > wrote: > > At least on socfpga gen5, _debug_uart_putc() can be called > > before debug_uart_init(), which leaves us stuck in an > > infinite loop in the ns16550 debug uart driver. > > Can

Re: [U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-08 Thread Simon Glass
Hi, On 7 October 2018 at 11:52, Simon Goldschmidt wrote: > At least on socfpga gen5, _debug_uart_putc() can be called > before debug_uart_init(), which leaves us stuck in an > infinite loop in the ns16550 debug uart driver. Can you fix that? That is a bug. > > Since this prevents debugging star

[U-Boot] [PATCH] debug uart: don't print before initialization

2018-10-07 Thread Simon Goldschmidt
At least on socfpga gen5, _debug_uart_putc() can be called before debug_uart_init(), which leaves us stuck in an infinite loop in the ns16550 debug uart driver. Since this prevents debugging startup problems instead of helping, let's add a field to 'gd' that prevents calling the _debug_uart_putc()