Re: [U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

2011-08-01 Thread Netagunte, Nagabhushana
Hi Mike, Thanks for your comments. Since the earlier patch is about reading env variable value in SPI flash and This patch concentrates on reading the same from I2C EEPROM, it will be better to have 2 different patches. Second patch is not to fix the first patch. If you want them to sent after s

Re: [U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

2011-08-01 Thread Netagunte, Nagabhushana
Mike, Thanks for your valuable comments; I will use the helper function you suggested. -Nag On Fri, Jul 29, 2011 at 00:01:39, Mike Frysinger wrote: > On Thu, Jul 28, 2011 at 09:25, >        if (getenv("ethaddr") == NULL) { > > this should get fixed to use the eth helper instead of poking the en

Re: [U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

2011-07-29 Thread Mike Frysinger
On Thu, Jul 28, 2011 at 11:31, Mike Frysinger wrote: > On Thu, Jul 28, 2011 at 09:25,  >        if (getenv("ethaddr") == NULL) { > > this should get fixed to use the eth helper instead of poking the env > yourself.  see board/bf537-stamp/bf537-stamp.c as an example. actually, it looks like this pa

Re: [U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

2011-07-28 Thread Mike Frysinger
On Thu, Jul 28, 2011 at 09:25,        if (getenv("ethaddr") == NULL) { this should get fixed to use the eth helper instead of poking the env yourself. see board/bf537-stamp/bf537-stamp.c as an example. -mike ___ U-Boot mailing list U-Boot@lists.denx.d

[U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

2011-07-28 Thread nagabhushana.netagunte
From: Nagabhushana Netagunte The AM18xx EVM contains MAC address in I2C EEPROM compared da850/omap-l138 Logic PD EVM which maintains in SPI flash. So this patch tries to read MAC address from I2C EEPROM, in failure case reads from SPI flash assuming board to be da850/omap-l138 Logic PDS EVM. Sig