Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread Clemens Gruber
Hi Fabio, Hi York, On Thu, Jan 04, 2018 at 07:59:13PM -0200, Fabio Estevam wrote: > Hi Clemens, > > On Thu, Jan 4, 2018 at 7:31 PM, Fabio Estevam wrote: > > Hi York, > > > > On Thu, Jan 4, 2018 at 7:12 PM, York Sun wrote: > > > >> This patch causes errors in almost all Freescale secure boot tar

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread Fabio Estevam
Hi Clemens, On Thu, Jan 4, 2018 at 7:31 PM, Fabio Estevam wrote: > Hi York, > > On Thu, Jan 4, 2018 at 7:12 PM, York Sun wrote: > >> This patch causes errors in almost all Freescale secure boot targets, > ... > >> The error is undefined reference to `BLOB_SIZE'. Please fix. > > You are right. Th

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread Fabio Estevam
Hi York, On Thu, Jan 4, 2018 at 7:12 PM, York Sun wrote: > This patch causes errors in almost all Freescale secure boot targets, ... > The error is undefined reference to `BLOB_SIZE'. Please fix. You are right. The BLOB_SIZE() macro is currently only defined for imx. Clemens, Please include

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread York Sun
On 01/04/2018 09:15 AM, York Sun wrote: > On 01/04/2018 01:39 AM, Fabio Estevam wrote: >> Hi York, >> >> On Wed, Jan 3, 2018 at 3:26 PM, Tom Rini wrote: >>> On Wed, Jan 03, 2018 at 02:32:44PM -0200, Fabio Estevam wrote: Hi Tom, On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber w

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread York Sun
On 01/04/2018 01:39 AM, Fabio Estevam wrote: > Hi York, > > On Wed, Jan 3, 2018 at 3:26 PM, Tom Rini wrote: >> On Wed, Jan 03, 2018 at 02:32:44PM -0200, Fabio Estevam wrote: >>> Hi Tom, >>> >>> On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber >>> wrote: The blob_encap and blob_decap function

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-04 Thread Fabio Estevam
Hi York, On Wed, Jan 3, 2018 at 3:26 PM, Tom Rini wrote: > On Wed, Jan 03, 2018 at 02:32:44PM -0200, Fabio Estevam wrote: >> Hi Tom, >> >> On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber >> wrote: >> > The blob_encap and blob_decap functions were not flushing the dcache >> > before passing data

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-03 Thread Tom Rini
On Wed, Jan 03, 2018 at 02:32:44PM -0200, Fabio Estevam wrote: > Hi Tom, > > On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber > wrote: > > The blob_encap and blob_decap functions were not flushing the dcache > > before passing data to CAAM/DMA and not invalidating the dcache when > > getting data

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2018-01-03 Thread Fabio Estevam
Hi Tom, On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber wrote: > The blob_encap and blob_decap functions were not flushing the dcache > before passing data to CAAM/DMA and not invalidating the dcache when > getting data back. > Therefore, blob encapsulation and decapsulation failed with errors li

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2017-12-21 Thread Clemens Gruber
Hi Breno, On Thu, Dec 21, 2017 at 07:18:44PM -0200, Breno Matheus Lima wrote: > Hi Clemens, > > 2017-12-20 20:08 GMT-02:00 Clemens Gruber : > > The blob_encap and blob_decap functions were not flushing the dcache > > before passing data to CAAM/DMA and not invalidating the dcache when > > getting

Re: [U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2017-12-21 Thread Breno Matheus Lima
Hi Clemens, 2017-12-20 20:08 GMT-02:00 Clemens Gruber : > The blob_encap and blob_decap functions were not flushing the dcache > before passing data to CAAM/DMA and not invalidating the dcache when > getting data back. > Therefore, blob encapsulation and decapsulation failed with errors like > the

[U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

2017-12-20 Thread Clemens Gruber
The blob_encap and blob_decap functions were not flushing the dcache before passing data to CAAM/DMA and not invalidating the dcache when getting data back. Therefore, blob encapsulation and decapsulation failed with errors like the following due to data cache incoherency: "4006: DECO: desc idx