Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-08 Thread Wolfgang Denk
Dear Anatolij, In message <20121108120224.3b377929@wker> you wrote: > On Wed, 7 Nov 2012 23:23:50 +0100 > Anatolij Gustschin wrote: > ... > > Applied to staging/ag...@denx.de. Thanks! > > I'll drop this patch as requested by Wolfgang. But we have also to revert the other commit, to make "help"

Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-08 Thread Anatolij Gustschin
On Wed, 7 Nov 2012 23:23:50 +0100 Anatolij Gustschin wrote: ... > Applied to staging/ag...@denx.de. Thanks! I'll drop this patch as requested by Wolfgang. Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listi

Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-08 Thread Wolfgang Denk
Dear Kim Phillips, In message <20121105195111.8a326673862d0552354e2...@freescale.com> you wrote: > commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse > fixes" broke the help command trying to fix the sparse error > "command.c:44:38: error: bad constant expression". > > As Henrik

Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-07 Thread Anatolij Gustschin
Hi, On Mon, 5 Nov 2012 19:51:11 -0600 Kim Phillips wrote: > commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse > fixes" broke the help command trying to fix the sparse error > "command.c:44:38: error: bad constant expression". > > As Henrik points out, the fix was bad because

Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-07 Thread Simon Glass
On Mon, Nov 5, 2012 at 9:44 PM, Henrik Nordström wrote: > mån 2012-11-05 klockan 19:51 -0600 skrev Kim Phillips: >> commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse >> fixes" broke the help command trying to fix the sparse error >> "command.c:44:38: error: bad constant expressi

Re: [U-Boot] [PATCH] common: fix help command breakage

2012-11-05 Thread Henrik Nordström
mån 2012-11-05 klockan 19:51 -0600 skrev Kim Phillips: > commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse > fixes" broke the help command trying to fix the sparse error > "command.c:44:38: error: bad constant expression". > > As Henrik points out, the fix was bad because the co

[U-Boot] [PATCH] common: fix help command breakage

2012-11-05 Thread Kim Phillips
commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse fixes" broke the help command trying to fix the sparse error "command.c:44:38: error: bad constant expression". As Henrik points out, the fix was bad because the commit used CONFIG_SYS_MAXARGS whereas the code intended to use the