Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-10 Thread Simon Glass
Hi Wolfgang, On 6 December 2015 at 23:28, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > I think your change would causes non-standard shell behaviour. >> > >> > If you want to evaluate variables, you have to do so as part of a >> > "run" command... >> >> I find the r

Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I think your change would causes non-standard shell behaviour. > > > > If you want to evaluate variables, you have to do so as part of a > > "run" command... > > I find the recursive behaviour much more useful. In particular we have > to jump through all

Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-06 Thread Simon Glass
Hi, On 4 December 2015 at 13:20, Wolfgang Denk wrote: > Dear Nishanth Menon, > > In message <1449255744-25787-1-git-send-email...@ti.com> you wrote: >> When we use the following in bootargs: >> v1=abc >> v2=123-${v1} >> echo ${v2} >> we get 123-${v1} >> when we should have got >> 123-abc >> This

Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-04 Thread Wolfgang Denk
Dear Nishanth Menon, In message <1449255744-25787-1-git-send-email...@ti.com> you wrote: > When we use the following in bootargs: > v1=abc > v2=123-${v1} > echo ${v2} > we get 123-${v1} > when we should have got > 123-abc > This is because we do not recursively check to see if v2 by itself has > a

[U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-04 Thread Nishanth Menon
When we use the following in bootargs: v1=abc v2=123-${v1} echo ${v2} we get 123-${v1} when we should have got 123-abc This is because we do not recursively check to see if v2 by itself has a hidden variable. Fix the same with recursive call. NOTE: this is a limited implementation as the next leve