Re: [U-Boot] [PATCH] common: board_f: cosmetic use __weak for leds

2014-07-08 Thread Simon Glass
On 23 June 2014 15:20, Jeroen Hofstee wrote: > First of all this looks a lot better, but it also > prevents a gcc warning (W=1), that the weak function > has no previous prototype. > > cc: Simon Glass > Signed-off-by: Jeroen Hofstee Build tested for sandbox and a few ARM boards. Acked-by: Simo

[U-Boot] [PATCH] common: board_f: cosmetic use __weak for leds

2014-06-23 Thread Jeroen Hofstee
First of all this looks a lot better, but it also prevents a gcc warning (W=1), that the weak function has no previous prototype. cc: Simon Glass Signed-off-by: Jeroen Hofstee --- This likely causes some merge issues, but is so uggly it deserves it. --- common/board_f.c | 29 ++