Re: [U-Boot] [PATCH] cmd: booti: fix the image runtime location

2016-09-13 Thread Tom Rini
On Tue, Sep 13, 2016 at 02:02:53PM +0800, Peng Fan wrote: > Hi Tom, > > On Mon, Sep 12, 2016 at 08:04:01AM -0400, Tom Rini wrote: > >On Mon, Sep 12, 2016 at 05:18:53PM +0800, Peng Fan wrote: > >> On Mon, Sep 12, 2016 at 05:07:58PM +0800, Peng Fan wrote: > >> >We should not use "bi_dram[0].start +

Re: [U-Boot] [PATCH] cmd: booti: fix the image runtime location

2016-09-12 Thread Peng Fan
Hi Tom, On Mon, Sep 12, 2016 at 08:04:01AM -0400, Tom Rini wrote: >On Mon, Sep 12, 2016 at 05:18:53PM +0800, Peng Fan wrote: >> On Mon, Sep 12, 2016 at 05:07:58PM +0800, Peng Fan wrote: >> >We should not use "bi_dram[0].start + text_offset" as the image dst. >> >The text_offset maybe 0 for some im

Re: [U-Boot] [PATCH] cmd: booti: fix the image runtime location

2016-09-12 Thread Tom Rini
On Mon, Sep 12, 2016 at 05:18:53PM +0800, Peng Fan wrote: > On Mon, Sep 12, 2016 at 05:07:58PM +0800, Peng Fan wrote: > >We should not use "bi_dram[0].start + text_offset" as the image dst. > >The text_offset maybe 0 for some images, such as XEN. Then the dst > >is actually bi_dram[0].start, which

Re: [U-Boot] [PATCH] cmd: booti: fix the image runtime location

2016-09-12 Thread Peng Fan
On Mon, Sep 12, 2016 at 05:07:58PM +0800, Peng Fan wrote: >We should not use "bi_dram[0].start + text_offset" as the image dst. >The text_offset maybe 0 for some images, such as XEN. Then the dst >is actually bi_dram[0].start, which maybe the location of spin table. > >Let's use "images->ep & ~(ih-

[U-Boot] [PATCH] cmd: booti: fix the image runtime location

2016-09-12 Thread Peng Fan
We should not use "bi_dram[0].start + text_offset" as the image dst. The text_offset maybe 0 for some images, such as XEN. Then the dst is actually bi_dram[0].start, which maybe the location of spin table. Let's use "images->ep & ~(ih->text_offset)" as the dst address. Signed-off-by: Peng Fan Cc